Closed Bug 1282947 Opened 7 years ago Closed 7 years ago

cors-makeheader.py does not set Location header of 3xx response

Categories

(Testing :: web-platform-tests, defect)

Product:
Testing
Component:
web-platform-tests
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: deckycoss, Assigned: deckycoss)

Details

Attachments

(1 file)

Bug 1282947: parse 'code' GET parameter as integer in cors-makeheader.py;
58 bytes, text/x-review-board-request
jdm
: review+
Details 
the cors/preflight-redirect test is currently failing due to a bug in cors-makeheader.py:

https://hg.mozilla.org/mozilla-central/file/4ed716e92a9d/testing/web-platform/tests/cors/resources/cors-makeheader.py#l45

this expression is always false because the code is not converted to an integer before the comparison is made. thus, the Location header is never set in the post-preflight response. fixing this should allow the test to pass.
Comment on attachment 8768517 [details]
Bug 1282947: parse 'code' GET parameter as integer in cors-makeheader.py;

https://reviewboard.mozilla.org/r/62710/#review59616
Attachment #8768517 - Flags: review?(josh) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90e2eea25b34
Parse 'code' GET parameter as integer in cors-makeheader.py. r=jdm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/90e2eea25b34
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.