Closed
Bug 1282947
Opened 8 years ago
Closed 8 years ago
cors-makeheader.py does not set Location header of 3xx response
Categories
(Testing :: web-platform-tests, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: deckycoss, Assigned: deckycoss)
Details
Attachments
(1 file)
the cors/preflight-redirect test is currently failing due to a bug in cors-makeheader.py: https://hg.mozilla.org/mozilla-central/file/4ed716e92a9d/testing/web-platform/tests/cors/resources/cors-makeheader.py#l45 this expression is always false because the code is not converted to an integer before the comparison is made. thus, the Location header is never set in the post-preflight response. fixing this should allow the test to pass.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/62710/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62710/
Attachment #8768517 -
Flags: review?(josh)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8768517 [details] Bug 1282947: parse 'code' GET parameter as integer in cors-makeheader.py; https://reviewboard.mozilla.org/r/62710/#review59616
Attachment #8768517 -
Flags: review?(josh) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a8ef8ed5044
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/90e2eea25b34 Parse 'code' GET parameter as integer in cors-makeheader.py. r=jdm
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/90e2eea25b34
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•