Closed Bug 1282980 Opened 7 years ago Closed 7 years ago

Remove MacQuirks

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

Remove MacQuirks
9.41 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
MacQuirks was targeted for OSX from 10.6.8 up to but not including 10.7.0. We
have now removed support for 10.6 so we can safely remove this code. This also
fixes bug 1282184 where DMD is apparently choking on memory allocated in the
interpose library.
Attached patch Remove MacQuirks — — Splinter Review 
Jeff it looks like you added this code back in 2011 in bug 694039, would you
mind taking a look?

I'm reasonably sure this code is unused, but you might want to double
check the version logic to make sure I'm interpreting it correctly.
Attachment #8766105 - Flags: review?(jmuizelaar)
Sorry I misstated, this fixes bug 1282185.
Blocks: 1282185
No longer blocks: 1282184
Attachment #8766105 - Flags: review?(jmuizelaar) → review+
Blocks: 1286973
backed out due to windows build failure
http://hg.mozilla.org/integration/mozilla-inbound/rev/fcb6731a7e2b

I think that you should fix nsBrowserApp.cpp
s/windows/OSX/
https://hg.mozilla.org/mozilla-central/rev/1f8e7ac750be
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.