Closed Bug 1282985 Opened 3 years ago Closed 3 years ago

"ASSERTION: No Document Request!" with <iframe>, <video>, <svg:use>

Categories

(Core :: Document Navigation, defect)

Product:
Core
Component:
Document Navigation
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jruderman, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase
790 bytes, image/svg+xml
Details
stack
5.24 KB, text/plain
Details
docloader_unusual_reentrancy.diff
4.46 KB, patch
khuey
: review+
Details | Diff | Splinter Review
Attached image testcase — 
###!!! ASSERTION: No Document Request!: 'mDocumentRequest', file uriloader/base/nsDocLoader.cpp, line 695

###!!! ASSERTION: Firing OnStateChange(...) notification with a NULL request!: 'aRequest', file uriloader/base/nsDocLoader.cpp, line 1248
Attached file stack — 
ok, so because of flushing in nsDocLoader::DocLoaderIsEmpty we re-enter the method and end up clearing document request.
Blocks: 477880
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dda0bdc51eb0e9d69b4f741af752fb2805f8ccc

I went through couple of other options, but I think this quick-and-dirty is actually the best and safest.
The re-entrancy happens when we after layout flush run script runners and stop frameloader's docshell.
Assignee: nobody → bugs
Flags: needinfo?(bugs)
Attachment #8766585 - Flags: review?(khuey)
Comment on attachment 8766585 [details] [diff] [review]
docloader_unusual_reentrancy.diff

Review of attachment 8766585 [details] [diff] [review]:
-----------------------------------------------------------------

Ok ... I guess.
Attachment #8766585 - Flags: review?(khuey) → review+
Is there a more direct way to test this kind of thing? The fragile setTimeout cascade was hard to work with and won't make a reliable regression test.
perhaps dholbert might be able to comment about that, given that this is about svg:use, which does some rather unusual stuff in layout.
Flags: needinfo?(dholbert)
Sorry, I haven't had a recent enough interaction with the <use> mechanics (and the flushes / loader stuff involved here) to have a solid suggestion for comment 6.
Flags: needinfo?(dholbert)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fc0469634a5
don't try to notify about page load of already stopped page, r=khuey
https://hg.mozilla.org/mozilla-central/rev/3fc0469634a5
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.