Closed Bug 1283060 Opened 4 years ago Closed 4 years ago

[Static Analysis][Dereference after null check] In function logging::TreeInfo

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1362639)

Attachments

(1 file)

The Static Analysis tool Coverity detected that a dereference after null check is performed on variable |aAcc|:

>>    MsgBegin("TREE", "%s; doc: %p", aMsg, aAcc ? aAcc->Document() : nullptr);
>>    AccessibleInfo(aMsg1, aAcc);
>>    Accessible* acc = aAcc->Document()->GetAccessible(aNode);
Component: Audio/Video: GMP → Disability Access APIs
Comment on attachment 8766258 [details]
Bug 1283060 - prevent null pointer dereference in logging::TreeInfo. .alexander

https://reviewboard.mozilla.org/r/61236/#review58706
Attachment #8766258 - Flags: review?(surkov.alexander) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/007ef3f639fa
prevent null pointer dereference in logging::TreeInfo. r=surkov.alexander
https://hg.mozilla.org/mozilla-central/rev/007ef3f639fa
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.