1283060 - [Static Analysis][Dereference after null check] In function logging::TreeInfo

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that a dereference after null check is performed on variable |aAcc|:

>>    MsgBegin("TREE", "%s; doc: %p", aMsg, aAcc ? aAcc->Document() : nullptr);
>>    AccessibleInfo(aMsg1, aAcc);
>>    Accessible* acc = aAcc->Document()->GetAccessible(aNode);

Comment 1

[Andi [:andi]]

Attachment: Bug 1283060 - prevent null pointer dereference in logging::TreeInfo. .alexander

Review commit: https://reviewboard.mozilla.org/r/61236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61236/

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8766258 [details]
Bug 1283060 - prevent null pointer dereference in logging::TreeInfo. .alexander

https://reviewboard.mozilla.org/r/61236/#review58706

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/007ef3f639fa
prevent null pointer dereference in logging::TreeInfo. r=surkov.alexander

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/007ef3f639fa