The machine model should inherit from the NamedModel class, since that's all it essentially is (the only difference is it has a db_index property set on the name, but that's unnecessary since it is implied by the unique property)
Assignee: nobody → wlachance
Comment on attachment 8766298 [details] [review] [treeherder] wlach:1283087 > mozilla:master This change incidentally removes an unnecessary double index on the "name" property (unique=True generates the necessary index by itself).
Attachment #8766298 - Flags: review?(emorley)
Comment on attachment 8766298 [details] [review] [treeherder] wlach:1283087 > mozilla:master Liking all the cleanup :-)
Attachment #8766298 - Flags: review?(emorley) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/be6bda2483472020f418b47de09692e5965b9697 Bug 1283087 - Machine reference data model should inherit from NamedModel (#1628)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.