Closed
Bug 1283091
Opened 7 years ago
Closed 7 years ago
TC android builds should use the same gecko.v2 routes as buildbot
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mshal, Unassigned)
References
Details
Attachments
(1 file)
The TC android builds use 'mobile.android-debug' while the buildbot/mozharness builds use 'mobile.android-api-15-debug' in the index for Android API-15 builds. I think the TC builds should use the same routes as buildbot, so when they are bumped to tier 1 there will be a seamless transition. This should simply involve changing the build_name parameter in the android_api_15.yml / android_api_15_debug.yml files to 'android-api-15', which a push to try can verify.
Comment 1•7 years ago
|
||
poking at this. braindump even though mshal summarized what needs to be done: bbot based fennec debug build: task_url: https://tools.taskcluster.net/task-inspector/#EjNdOkD2TAe2OHVO-slLyg/ routes: index.gecko.v2.try.revision.6a26abbddbafbb81df35e3ed2da197baf97875a3.mobile.android-api-15-debug index.gecko.v2.try.pushdate.2016.07.11.20160711172644.mobile.android-api-15-debug index.gecko.v2.try.latest.mobile.android-api-15-debug (non gecko.v2) index.buildbot.branches.try.android-api-15-debug index.buildbot.revisions.6a26abbddbafbb81df35e3ed2da197baf97875a3.try.android-api-15-debug tc based fennec debug build: task_url: https://tools.taskcluster.net/task-inspector/#c6C-3Q3ZSY-NQ8TrCoiNHw/ routes: index.gecko.v2.try.revision.6a26abbddbafbb81df35e3ed2da197baf97875a3.mobile.android-debug index.gecko.v2.try.pushdate.2016.07.11.20160711172644.mobile.android-debug index.gecko.v2.try.latest.mobile.android-debug (non gecko.v2) index.gecko.v1.try.revision.linux.6a26abbddbafbb81df35e3ed2da197baf97875a3.android.debug index.gecko.v1.try.latest.linux.android.debug index.buildbot.branches.try.android-api-15-dbg index.buildbot.revisions.6a26abbddbafbb81df35e3ed2da197baf97875a3.try.android-api-15-dbg tc-treeherder.v2.try.6a26abbddbafbb81df35e3ed2da197baf97875a3.133396 tc-treeherder-stage.v2.try.6a26abbddbafbb81df35e3ed2da197baf97875a3.133396 OOC - should I be changing `android-api-15-dbg` to s/dbg/debug for index.buildbot? speaking of which, do we want these routes via taskcluster? The answer is likely outside of the scope here as it is builder wide iiuc - https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/tasks/builds/android_api_15.yml#14 - https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/tasks/builds/android_api_15_debug.yml#14 I tried going back the fennec hierarchy path looking for index.gecko.v2 declaration but couldn't find it: `build.yml->docker_build.yml->mobile_base.yml->android_api_15_debug.yml` it seems like, at least in legacy structure, index.gecko.v2 is shared among many (all?) build files: - https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/routes.json?q=path%3Aroutes+path%3Ataskcluster&redirect_type=single#2-6 - https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/kind/legacy.py#476 which now makes sense why you suggested changing build_name property. :) I'll push to try and see if modifying build_name causes spurious results.
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Jordan Lund (:jlund) from comment #1) > OOC - should I be changing `android-api-15-dbg` to s/dbg/debug for > index.buildbot? speaking of which, do we want these routes via taskcluster? Oh, good catch - I didn't notice the dbg used there. Yes, they should be included by taskcluster builds and should match the buildbot ones for the time being. Artifact builds still use the buildbot.* routes, so if you want them to pick up the Taskcluster android build when it is promoted to tier 1, you'll need to match the buildbot.* route by changing the 'routes' in the yml file. > it seems like, at least in legacy structure, index.gecko.v2 is shared among > many (all?) build files: > - > https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/routes. > json?q=path%3Aroutes+path%3Ataskcluster&redirect_type=single#2-6 Yes, gecko.v2 is shared and specified by routes.json. It is also used by mozharness for buildbot builds. However, Taskcluster and buildbot generally need to agree by matching the build_name/build_type with what mozharness uses for platform / build type. > I'll push to try and see if modifying build_name causes spurious results. Hopefully that (and fixing the dbg buildbot routes) is all that's needed. Thanks!
Comment 4•7 years ago
|
||
note, as bug 1281004 is about to land, I might require a new patch as we move away from legacy towards da futures! this yielded: current bbot opt routes: "index.gecko.v2.try.revision.f40f15f50508b78e369c8ac5e6a8743bcd064193.mobile.android-api-15-opt", "index.gecko.v2.try.pushdate.2016.07.11.20160711204636.mobile.android-api-15-opt", "index.gecko.v2.try.latest.mobile.android-api-15-opt", "index.buildbot.branches.try.android-api-15", "index.buildbot.revisions.f40f15f50508b78e369c8ac5e6a8743bcd064193.try.android-api-15" my patch tc opt routes: "index.gecko.v1.try.revision.linux.f40f15f50508b78e369c8ac5e6a8743bcd064193.android-api-15.opt", "index.gecko.v1.try.latest.linux.android-api-15.opt", "index.buildbot.branches.try.android-api-15", "index.buildbot.revisions.f40f15f50508b78e369c8ac5e6a8743bcd064193.try.android-api-15", "tc-treeherder.v2.try.f40f15f50508b78e369c8ac5e6a8743bcd064193.133427", "tc-treeherder-stage.v2.try.f40f15f50508b78e369c8ac5e6a8743bcd064193.133427", "index.gecko.v2.try.revision.f40f15f50508b78e369c8ac5e6a8743bcd064193.mobile.android-api-15-opt", "index.gecko.v2.try.pushdate.2016.07.11.20160711204636.mobile.android-api-15-opt", "index.gecko.v2.try.latest.mobile.android-api-15-opt" current bbot debug routes: "index.gecko.v2.try.revision.f40f15f50508b78e369c8ac5e6a8743bcd064193.mobile.android-api-15-debug", "index.gecko.v2.try.pushdate.2016.07.11.20160711204636.mobile.android-api-15-debug", "index.gecko.v2.try.latest.mobile.android-api-15-debug", "index.buildbot.branches.try.android-api-15-debug", "index.buildbot.revisions.f40f15f50508b78e369c8ac5e6a8743bcd064193.try.android-api-15-debug" my patch tc debug routes: "index.gecko.v1.try.revision.linux.f40f15f50508b78e369c8ac5e6a8743bcd064193.android-api-15.debug", "index.gecko.v1.try.latest.linux.android-api-15.debug", "index.buildbot.branches.try.android-api-15-debug", "index.buildbot.revisions.f40f15f50508b78e369c8ac5e6a8743bcd064193.try.android-api-15-debug", "tc-treeherder.v2.try.f40f15f50508b78e369c8ac5e6a8743bcd064193.133427", "tc-treeherder-stage.v2.try.f40f15f50508b78e369c8ac5e6a8743bcd064193.133427", "index.gecko.v2.try.revision.f40f15f50508b78e369c8ac5e6a8743bcd064193.mobile.android-api-15-debug", "index.gecko.v2.try.pushdate.2016.07.11.20160711204636.mobile.android-api-15-debug", "index.gecko.v2.try.latest.mobile.android-api-15-debug" so all looks well and as a bonus, the index.buildbot routes now match too. Review commit: https://reviewboard.mozilla.org/r/63592/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63592/
Attachment #8769939 -
Flags: review?(mshal)
Reporter | ||
Comment 5•7 years ago
|
||
Comment on attachment 8769939 [details] Bug 1283091 - TC android builds should use the same gecko.v2 routes as buildbot, https://reviewboard.mozilla.org/r/63592/#review60728 Looks great! Thanks for fixing this.
Attachment #8769939 -
Flags: review?(mshal) → review+
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/45f93ac702cbcc2e489f82069082113a994c2e12 Bug 1283091 - TC android builds should use the same gecko.v2 routes as buildbot, r=mshal
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/45f93ac702cb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•