Closed Bug 1283092 Opened 4 years ago Closed 4 years ago
[Static Analysis][Uninitialized pointer field] In constructor GLXDisplay
58 bytes, text/x-review-board-request
The Static Analysis tool Coverity detected that member variable |mXDisplay| is not initialised in the constructor. I see that it is initialised outside by function Setup->SetupGLContext I think we could initialise it with nullptr since it's very cheap and by doing this we avoid marking at for skipping the initialisation checker performed by the clang-plugin. The following bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1282408 servers as the meta bug where we put all of the patches that are created for the variables that we want to be skipped during analysis.
Review commit: https://reviewboard.mozilla.org/r/61282/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61282/
Attachment #8766314 - Flags: review?(jmuizelaar)
Attachment #8766314 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8766314 [details] Bug 1283092 - initialise member variable |mXDisplay|. https://reviewboard.mozilla.org/r/61282/#review58404
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/0b51143888a6 initialise member variable |mXDisplay|. r=jrmuizel
You need to log in before you can comment on or make changes to this bug.