Closed Bug 1283092 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized pointer field] In constructor GLXDisplay

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1362652)

Attachments

(1 file)

The Static Analysis tool Coverity detected that member variable |mXDisplay| is not initialised in the constructor. I see that it is initialised outside by function Setup->SetupGLContext

I think we could initialise it with nullptr since it's very cheap and by doing this we avoid marking at for skipping the initialisation checker performed by the clang-plugin. 
The following bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1282408 servers as the meta bug where we put all of the patches that are created for the variables that we want to be skipped during analysis.
Attachment #8766314 - Flags: review?(jmuizelaar) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b51143888a6
initialise member variable |mXDisplay|. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/0b51143888a6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.