Closed
Bug 1283129
Opened 8 years ago
Closed 8 years ago
[mozlint] Flake8 is linting some eslint related .lint files
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(1 file)
If you run |mach eslint| it will install a bunch of node_modules that contain some .lint files in them. The flake8 linter is wrongfully picking these up.
Assignee | ||
Comment 1•8 years ago
|
||
If you run |mach eslint| it will install a bunch of eslint related node_modules. Some of these modules have '.lint' files in them which erroneously get picked up by the flake8 linter. This patch makes sure that bare '.lint' files do not get included, they must have some kind of file name first. Review commit: https://reviewboard.mozilla.org/r/61290/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61290/
Attachment #8766354 -
Flags: review?(mjzffr)
Attachment #8766354 -
Flags: review?(mjzffr) → review+
Comment on attachment 8766354 [details] Bug 1283129 - Flake8 linter is accidentally linting some eslint related .lint files, https://reviewboard.mozilla.org/r/61290/#review58180
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63214a08673f Flake8 linter is accidentally linting some eslint related .lint files, r=maja_zf
Assignee | ||
Updated•8 years ago
|
Component: General → Lint
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/63214a08673f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•6 years ago
|
Product: Testing → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•