Closed Bug 1283129 Opened 4 years ago Closed 4 years ago

[mozlint] Flake8 is linting some eslint related .lint files

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

If you run |mach eslint| it will install a bunch of node_modules that contain some .lint files in them. The flake8 linter is wrongfully picking these up.
If you run |mach eslint| it will install a bunch of eslint related node_modules. Some of these
modules have '.lint' files in them which erroneously get picked up by the flake8 linter. This
patch makes sure that bare '.lint' files do not get included, they must have some kind of file
name first.

Review commit: https://reviewboard.mozilla.org/r/61290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61290/
Attachment #8766354 - Flags: review?(mjzffr)
Attachment #8766354 - Flags: review?(mjzffr) → review+
Comment on attachment 8766354 [details]
Bug 1283129 - Flake8 linter is accidentally linting some eslint related .lint files,

https://reviewboard.mozilla.org/r/61290/#review58180
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63214a08673f
Flake8 linter is accidentally linting some eslint related .lint files, r=maja_zf
Component: General → Lint
https://hg.mozilla.org/mozilla-central/rev/63214a08673f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.