[mozlint] Flake8 is linting some eslint related .lint files

RESOLVED FIXED in Firefox 50

Status

Testing
Lint
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
If you run |mach eslint| it will install a bunch of node_modules that contain some .lint files in them. The flake8 linter is wrongfully picking these up.
(Assignee)

Comment 1

2 years ago
Created attachment 8766354 [details]
Bug 1283129 - Flake8 linter is accidentally linting some eslint related .lint files,

If you run |mach eslint| it will install a bunch of eslint related node_modules. Some of these
modules have '.lint' files in them which erroneously get picked up by the flake8 linter. This
patch makes sure that bare '.lint' files do not get included, they must have some kind of file
name first.

Review commit: https://reviewboard.mozilla.org/r/61290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61290/
Attachment #8766354 - Flags: review?(mjzffr)
Attachment #8766354 - Flags: review?(mjzffr) → review+
Comment on attachment 8766354 [details]
Bug 1283129 - Flake8 linter is accidentally linting some eslint related .lint files,

https://reviewboard.mozilla.org/r/61290/#review58180

Comment 3

2 years ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63214a08673f
Flake8 linter is accidentally linting some eslint related .lint files, r=maja_zf
(Assignee)

Updated

2 years ago
Component: General → Lint

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/63214a08673f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.