Closed Bug 1283176 Opened 3 years ago Closed 3 years ago

Dump more useful values for sticky-position items in the layer dump

Categories

(Core :: Graphics: Layers, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

For layers that are position:sticky, we currently dump the x,y,width,height of the inner and outer scroll ranges. However the width and height are not really useful here, since the code that uses these scroll ranges uses the XMost() and YMost() values. So we should print those for more meaningful output. Note that since the ranges are initialized based on nscoord_MIN and nscoord_MAX [1] we often (legitimately) get very large negative and positive values in these rects, which makes it even harder to figure out what's going on. Using the XMost() and YMost() brings a small amount of sanity to this situation.

[1] http://searchfox.org/mozilla-central/rev/261fe13dcd88cfd2e99e65755e7ca4b7a2e583df/layout/generic/StickyScrollContainer.cpp#287
Comment on attachment 8766397 [details]
Bug 1283176 - Dump XMost and YMost values instead of width and height for sticky layers.

https://reviewboard.mozilla.org/r/61310/#review58206
Attachment #8766397 - Flags: review?(nical.bugzilla) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b74631965e4
Dump XMost and YMost values instead of width and height for sticky layers. r=nical
https://hg.mozilla.org/mozilla-central/rev/9b74631965e4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.