1283313 - broken --disable-gamepad: dom/bindings/GamepadServiceTestBinding.cpp:10:44: fatal error: mozilla/dom/GamepadServiceTest.h: No such file or directory

Status: RESOLVED DUPLICATE of bug 1282993

(Firefox OS Graveyard :: General, defect)

Comment 1

[:gerard-majax]

Attachment: Bug 1283313 - Followup bug 1283135 and fix Gamepad includes

Review commit: https://reviewboard.mozilla.org/r/61398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61398/

Comment 2

[:gerard-majax]

This is not yet good, I am facing link time issues:
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: error: /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/objdir-gecko/toolkit/library/../../ipc/glue/BackgroundChildImpl.o: requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: error: /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/objdir-gecko/toolkit/library/../../ipc/glue/BackgroundChildImpl.o: requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: error: /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/objdir-gecko/toolkit/library/../../ipc/glue/BackgroundParentImpl.o: requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: error: /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/objdir-gecko/toolkit/library/../../ipc/glue/BackgroundParentImpl.o: requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: error: /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/objdir-gecko/toolkit/library/../../ipc/glue/BackgroundParentImpl.o: requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: error: read-only segment has dynamic relocations
../../../../../../HG/pine/ipc/glue/BackgroundChildImpl.cpp:517: error: undefined reference to 'vtable for mozilla::dom::GamepadTestChannelChild'
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: the vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod)
../../../../../../HG/pine/ipc/glue/BackgroundChildImpl.cpp:502: error: undefined reference to 'vtable for mozilla::dom::GamepadEventChannelChild'
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: the vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod)
../../../../../../HG/pine/ipc/glue/BackgroundParentImpl.cpp:928: error: undefined reference to 'mozilla::dom::GamepadEventChannelParent::GamepadEventChannelParent()'
../../../../../../HG/pine/ipc/glue/BackgroundParentImpl.cpp:949: error: undefined reference to 'vtable for mozilla::dom::GamepadTestChannelParent'
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: the vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod)
../../../../../../HG/pine/ipc/glue/BackgroundParentImpl.cpp:958: error: undefined reference to 'vtable for mozilla::dom::GamepadTestChannelParent'
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: the vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod)
../../../../../../HG/pine/ipc/glue/BackgroundParentImpl.cpp:940: error: undefined reference to 'vtable for mozilla::dom::GamepadEventChannelParent'
/home/alex/codaz/Android/android-ndk-linux/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld: the vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod)
GamepadServiceTestBinding.cpp:193: error: undefined reference to 'mozilla::dom::GamepadServiceTest::NewButtonEvent(unsigned int, unsigned int, bool)'
GamepadServiceTestBinding.cpp:151: error: undefined reference to 'mozilla::dom::GamepadServiceTest::RemoveGamepad(unsigned int)'
GamepadServiceTestBinding.cpp:287: error: undefined reference to 'mozilla::dom::GamepadServiceTest::NewAxisMoveEvent(unsigned int, unsigned int, double)'
GamepadServiceTestBinding.cpp:242: error: undefined reference to 'mozilla::dom::GamepadServiceTest::NewButtonValueEvent(unsigned int, unsigned int, bool, double)'
GamepadServiceTestBinding.cpp:97: error: undefined reference to 'mozilla::dom::GamepadServiceTest::AddGamepad(nsAString_internal const&, unsigned int, unsigned int, unsigned int, mozilla::ErrorResult&)'

Comment 3

[Andrea Marchesini [:baku]]

Check what patch of bug 1282993 does for GamepadServiceTest.

Comment 4

[:gerard-majax]

Sure, I'm testing it

Comment 5

[:gerard-majax]

(In reply to Andrea Marchesini (:baku) from comment #3)
> Check what patch of bug 1282993 does for GamepadServiceTest.

That one works better.