Re-pushing a patch after "r?" was cleared doesn't revive the "r?"

RESOLVED INVALID

Status

defect
RESOLVED INVALID
3 years ago
6 months ago

People

(Reporter: gerald, Unassigned)

Tracking

Production

Details

STR:
1. Push a patch for review
2. Reviewer clears review flag (I think from mozreview, but not sure)
3. Modify commit message and push patch again

Expected:
Review flag is revived in both mozreview and bugzilla.

Actual:
Review flas is still cleared in mozreview.

Note: I have tried a few things between steps 2 and 3, which might have influenced things:
2.1: Finish review, set "r?" and publish. This set me as reviewer!
2.2: Tried to edit the reviewer name, but leaving it the same. Nothing seemed to happen.

And later:
3.1 In mozreview, change reviewer to me, publish (which seemed to work), change reviewer back, publish. But it's back to being cleared.

I think there should be some way to force-unclear the review flag.
Similarly I just pushed a new version of the part 3 patch in bug 1288302, where the reviewer cancelled review on the first version.  Now Bugzilla has r? set but mozreview still shows "r? cleared".
This is very confusing for new contributors, once the review is cleared is sticks to "r? cleared" and they can't fix it back. It makes complex to mentor bugs since they can't properly set requests to mentors.

Comment 4

6 months ago
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.