Closed Bug 1283340 Opened 3 years ago Closed 3 years ago

Current .ycm_extra_conf doesn't work for python3

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

No module named StringIO. I've got a patch for this.
Flagged gps for review since he was the reviewer for the original patch and Ehsan (the writer) seems to not be accepting review requests.
Assignee: nobody → ealvarez
Comment on attachment 8766609 [details]
Bug 1283340: python: fix .ycm_extra_conf.py for python 3

https://reviewboard.mozilla.org/r/61432/#review59232

This should work. Hopefully it doesn't get bogged up by string types in Python 3. Generally speaking, Python 3 support isn't well tested. So good luck.
Attachment #8766609 - Flags: review?(gps) → review+
https://reviewboard.mozilla.org/r/61432/#review59232

Thanks for the review! Fwiw I've been using this patch without a problem during the last few weeks.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dd8ef51f4920
python: fix .ycm_extra_conf.py for python 3 r=gps
https://hg.mozilla.org/mozilla-central/rev/dd8ef51f4920
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.