1283375 - Race condition when recycling plugin textures

Status: RESOLVED DUPLICATE of bug 1280839

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

I'm hitting a MOZ_ASSERT(!mLocked) assert in TextureClient when trying the Flash beta [1]. My guess is that we're posting a Recycle task to the ImageBridge thread, which races with us calling Lock() on the main thread.

Nical, does that analysis seem plausible, and if so, what can we do?

[1] https://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/TextureClient.cpp#752
[2] https://dxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/PluginInstanceParent.cpp#803

Comment 1

[Sotaro Ikeda [:sotaro]]

Yes, TextureClientRecycleTask has a problem. I just removed it by Bug 1280839. It is in m-i now.

Comment 2

[Sotaro Ikeda [:sotaro]]

To solve the race condition we need to remove TextureClientRecycleTask. And it is in Bug 1280839.

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to David Anderson [:dvander] from comment #0)
> 
> [1]
> https://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/
> TextureClient.cpp#752

The lock check is added by Bug 1266396. Then it affect firefox 49.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> To solve the race condition we need to remove TextureClientRecycleTask. And
> it is in Bug 1280839.

I received the test content offline and confirmed that Bug 1280839 addressed the MOZ_ASSERT(!mLocked) assert.