1283427 - (Potentially) remove SEC_NORMAL from NetUtil.jsm

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dc399002163

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Christoph, it seems this is the last use of SEC_NORMAL.  Do you think its possible to remove it now?

Comment 3

[Tom S. (please needinfo tschuster)]

I made a try push that throws when don't have securityFlags in newChannel. And removed SEC_NORMAL completely.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3112ab9c434a2a8e1257597a36d04c61356f36d4

Comment 4

[Tom S. (please needinfo tschuster)]

Looks really good. Just two newChannel failures in netwerk/test/unit/test_referrer.js and netwerk/test/unit/test_referrer_cross_origin.js.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Ben Kelly [:bkelly] from comment #2)
> Christoph, it seems this is the last use of SEC_NORMAL.  Do you think its
> possible to remove it now?

Yes, I think we can now.

Tom, since you are already on it, do you wanna push this bug over the finishing line? Looked at the code changes you pushed to TRY, looks pretty good to me.

The two test failures can simply use: SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL.

Comment 6

[Tom S. (please needinfo tschuster)]

Attachment: Remove SEC_NORMAL completely

Comment 7

[Tom S. (please needinfo tschuster)]

Attachment: Remove SEC_NORMAL from NetUtil.newChannel

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8944510 [details] [diff] [review]
Remove SEC_NORMAL from NetUtil.newChannel

Review of attachment 8944510 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Tom, that looks great. r=me

Comment 9

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8944509 [details] [diff] [review]
Remove SEC_NORMAL completely

Review of attachment 8944509 [details] [diff] [review]:
-----------------------------------------------------------------

same here, thanks. r=me

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46a76268e932
Remove SEC_NORMAL from NetUtil.newChannel. r=ckerschb
https://hg.mozilla.org/integration/mozilla-inbound/rev/49138c9a5858
Remove SEC_NORMAL completely. r=ckerschb

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/46a76268e932
https://hg.mozilla.org/mozilla-central/rev/49138c9a5858