Closed Bug 1283427 Opened 4 years ago Closed 2 years ago

(Potentially) remove SEC_NORMAL from NetUtil.jsm

Categories

(Core :: DOM: Security, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: ckerschb, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(2 files)

No description provided.
Blocks: 1006868
Whiteboard: [domsecurity-backlog]
Priority: -- → P3
Whiteboard: [domsecurity-backlog] → [domsecurity-backlog1]
Christoph, it seems this is the last use of SEC_NORMAL.  Do you think its possible to remove it now?
Flags: needinfo?(ckerschb)
I made a try push that throws when don't have securityFlags in newChannel. And removed SEC_NORMAL completely.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3112ab9c434a2a8e1257597a36d04c61356f36d4
Looks really good. Just two newChannel failures in netwerk/test/unit/test_referrer.js and netwerk/test/unit/test_referrer_cross_origin.js.
(In reply to Ben Kelly [:bkelly] from comment #2)
> Christoph, it seems this is the last use of SEC_NORMAL.  Do you think its
> possible to remove it now?

Yes, I think we can now.

Tom, since you are already on it, do you wanna push this bug over the finishing line? Looked at the code changes you pushed to TRY, looks pretty good to me.

The two test failures can simply use: SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL.
Flags: needinfo?(ckerschb) → needinfo?(evilpies)
Assignee: nobody → evilpies
Flags: needinfo?(evilpies)
Attachment #8944509 - Flags: review?(ckerschb)
Attachment #8944510 - Flags: review?(ckerschb)
Comment on attachment 8944510 [details] [diff] [review]
Remove SEC_NORMAL from NetUtil.newChannel

Review of attachment 8944510 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Tom, that looks great. r=me
Attachment #8944510 - Flags: review?(ckerschb) → review+
Comment on attachment 8944509 [details] [diff] [review]
Remove SEC_NORMAL completely

Review of attachment 8944509 [details] [diff] [review]:
-----------------------------------------------------------------

same here, thanks. r=me
Attachment #8944509 - Flags: review?(ckerschb) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46a76268e932
Remove SEC_NORMAL from NetUtil.newChannel. r=ckerschb
https://hg.mozilla.org/integration/mozilla-inbound/rev/49138c9a5858
Remove SEC_NORMAL completely. r=ckerschb
https://hg.mozilla.org/mozilla-central/rev/46a76268e932
https://hg.mozilla.org/mozilla-central/rev/49138c9a5858
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.