Closed Bug 1283439 Opened 4 years ago Closed 4 years ago
Types .h:146:12: error: 'sp' in namespace 'android' does not name a template type
654 bytes, patch
|Details | Diff | Splinter Review|
58 bytes, text/x-review-board-request
No description provided.
Summary: ../../dist/include/mozilla/layers/LayersTypes.h:124:12: error: 'mSurface' was not declared in this scope → ../../dist/include/mozilla/layers/LayersTypes.h:146:12: error: 'sp' in namespace 'android' does not name a template type
(In reply to Alexandre LISSY :gerard-majax from comment #1) > Created attachment 8766802 [details] [diff] [review] > difference between gonk's StrongPointer.h and the copy in > media/libstagefright living in Gecko tree This comes from bug 908503 attachment 8422882 [details] [diff] [review] and is explicitely done to keep things apart
We get to include LayersTypes.h from that MP4 parsing just because of the Rust parser added in bug 1267887 and the sharing operated in bug 1282963. The OpusDataDecoder class is only used in side the MP4MetadataRust::GetTrackInfo method and thus we can just avoid including OpusDecoder.h when MOZ_RUST_MP4PARSE is not defined.
Review commit: https://reviewboard.mozilla.org/r/61574/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61574/
Comment on attachment 8766849 [details] Bug 1283439 - Include OpusDecoder.h only for Rust MP4 parsing Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61574/diff/1-2/
Attachment #8766849 - Flags: review?(kinetik)
Comment on attachment 8766849 [details] Bug 1283439 - Include OpusDecoder.h only for Rust MP4 parsing https://reviewboard.mozilla.org/r/61574/#review58554
Attachment #8766849 - Flags: review?(kinetik) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f4c2575a96e8 Include OpusDecoder.h only for Rust MP4 parsing r=kinetik
You need to log in before you can comment on or make changes to this bug.