Closed Bug 1283439 Opened 4 years ago Closed 4 years ago

../../dist/include/mozilla/layers/LayersTypes.h:146:12: error: 'sp' in namespace 'android' does not name a template type

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(2 files)

No description provided.
Summary: ../../dist/include/mozilla/layers/LayersTypes.h:124:12: error: 'mSurface' was not declared in this scope → ../../dist/include/mozilla/layers/LayersTypes.h:146:12: error: 'sp' in namespace 'android' does not name a template type
No longer blocks: 1281780
(In reply to Alexandre LISSY :gerard-majax from comment #1)
> Created attachment 8766802 [details] [diff] [review]
> difference between gonk's StrongPointer.h and the copy in
> media/libstagefright living in Gecko tree

This comes from bug 908503 attachment 8422882 [details] [diff] [review] and is explicitely done to keep things apart
We get to include LayersTypes.h from that MP4 parsing just because of the Rust parser added in bug 1267887 and the sharing operated in bug 1282963. The OpusDataDecoder class is only used in side the MP4MetadataRust::GetTrackInfo method and thus we can just avoid including OpusDecoder.h when MOZ_RUST_MP4PARSE is not defined.
Blocks: 1282963
Assignee: nobody → lissyx+mozillians
Comment on attachment 8766849 [details]
Bug 1283439 - Include OpusDecoder.h only for Rust MP4 parsing

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61574/diff/1-2/
Attachment #8766849 - Flags: review?(kinetik)
Comment on attachment 8766849 [details]
Bug 1283439 - Include OpusDecoder.h only for Rust MP4 parsing

https://reviewboard.mozilla.org/r/61574/#review58554
Attachment #8766849 - Flags: review?(kinetik) → review+
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4c2575a96e8
Include OpusDecoder.h only for Rust MP4 parsing r=kinetik
https://hg.mozilla.org/mozilla-central/rev/f4c2575a96e8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.