1283444 - mach build faster does not work if WIN_UCRT_REDIST_DIR is set

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masatoshi Kimura [:emk]]

$ mach build faster
 0:03.05 c:\mozilla-build\mozmake\mozmake.EXE -C f:/m/mozilla-central/obj-x86_64-pc-mingw32 -j8 -s backend
 0:03.26 c:\mozilla-build\mozmake\mozmake.EXE -C faster -j8 -s
 0:03.49 source-repo.h
 0:03.49 buildid.h
 0:04.80 Elapsed: 1.13s; From dist/idl: Kept 0 existing; Added/updated 1151; Removed 0 files and 0 directories.
 0:05.19 Elapsed: 0.21s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/gmp-fakeopenh264/1.0: Kept 2 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:05.19 Elapsed: 0.14s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/browser/features/[e-mail]: Kept 81 existing; Added/updated 2; Removed 0 files and 0 directories.
 0:05.19 Elapsed: 0.13s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/gmp-fake/1.0: Kept 2 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:05.22 Traceback (most recent call last):
 0:05.22   File "c:\mozilla-build\python\Lib\runpy.py", line 162, in _run_module_as_main
 0:05.22     "__main__", fname, loader, pkg_name)
 0:05.22   File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
 0:05.22     exec code in run_globals
 0:05.22   File "f:\m\mozilla-central\python\mozbuild\mozbuild\action\process_install_manifest.py", line 112, in <module>
 0:05.22     main(sys.argv[1:])
 0:05.22   File "f:\m\mozilla-central\python\mozbuild\mozbuild\action\process_install_manifest.py", line 99, in main
 0:05.23     defines=args.defines)
 0:05.23   File "f:\m\mozilla-central\python\mozbuild\mozbuild\action\process_install_manifest.py", line 65, in process_manifest
 0:05.23     remove_empty_directories=remove_empty_directories)
 0:05.23   File "f:\m\mozilla-central\python\mozbuild\mozpack\copier.py", line 309, in copy
 0:05.23     os.mkdir(d)
 0:05.23 WindowsError: [Error 123] ファイル名、ディレクトリ名、またはボリューム ラベルの構文が間違っています。: u'f:\\m\\mozilla-central\\obj-x86_64-pc-mingw32\\dist\\bin\\api-ms-win-*.dll'
 0:05.25 f:/m/mozilla-central/config/faster/rules.mk:84: recipe for target 'install-dist/bin' failed
 0:05.25 mozmake.EXE: *** [install-dist/bin] Error 1
 0:05.25 mozmake.EXE: *** Waiting for unfinished jobs....
 0:05.25 Elapsed: 0.16s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/gmp-clearkey/0.1: Kept 0 existing; Added/updated 1; Removed 0 files and 0 directories.
 0:05.27 Elapsed: 0.31s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/browser/features/[e-mail]: Kept 0 existing; Added/updated 204; Removed 0 files and 0 directories.
 0:05.28 Elapsed: 0.05s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/browser/features/[e-mail]: Kept 20 existing; Added/updated 1; Removed 0 files and 0 directories.
 0:05.68 Elapsed: 0.16s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/browser/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}: Kept 0 existing; Added/updated 2; Removed 0 files and 0 directories.
 0:07.91 Elapsed: 2.95s; From f:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/bin/browser: Kept 0 existing; Added/updated 2491; Removed 0 files and 0 directories.
2

Comment 1

[Michael Shal [:mshal]]

Did this work previously? Maybe it was broken by bug 1245701 or possibly bug 1278700.

Comment 2

[Masatoshi Kimura [:emk]]

I don't know. I didn't set WIN_UCRT_REDIST_DIR because of bug 1245701.

Comment 3

[Masatoshi Kimura [:emk]]

Fixed by a patch for bug 1416465.