1283452 - Fix b2g phone task definition

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[:gerard-majax]

Attachment: Bug 1283452 - Fix task definition by forcing /bin/bash

Review commit: https://reviewboard.mozilla.org/r/61530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61530/

Comment 2

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/61530/#review58392

::: taskcluster/ci/legacy/tasks/builds/b2g_aries_spark_debug.yml:27
(Diff revision 1)
>        GAIA_OPTIMIZE: '1'
>        B2G_SYSTEM_APPS: '1'
>        MOZHARNESS_CONFIG: b2g/taskcluster-spark.py
>      command:
>        - >
> -        checkout-gecko workspace &&
> +        /bin/bash -c "checkout-gecko workspace &&

Hrm, I'm not sure off hand how this would behave when declared like this (a push to try would clear that up quickly though)

Typically we've done something like this:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/tasks/builds/base_linux64.yml#33

Comment 3

[:gerard-majax]

Comment on attachment 8766764 [details]
Bug 1283452 - Fix task definition by forcing /bin/bash

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61530/diff/1-2/

Comment 4

[:gerard-majax]

Comment on attachment 8766764 [details]
Bug 1283452 - Fix task definition by forcing /bin/bash

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61530/diff/2-3/

Comment 5

[:gerard-majax]

That one is good! https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ff4ece21b75&filter-tier=1&filter-tier=2&filter-tier=3

Comment 6

[Greg Arndt [:garndt]]

Comment on attachment 8766764 [details]
Bug 1283452 - Fix task definition by forcing /bin/bash

https://reviewboard.mozilla.org/r/61530/#review58526

::: taskcluster/ci/legacy/tasks/builds/b2g_aries_spark_debug.yml:25
(Diff revisions 2 - 3)
>        DEBUG: 0
>        VARIANT: userdebug
>        GAIA_OPTIMIZE: '1'
>        B2G_SYSTEM_APPS: '1'
>        MOZHARNESS_CONFIG: b2g/taskcluster-spark.py
> -    command:
> +    command: ["/bin/bash", "-c", "checkout-gecko workspace && cd ./workspace/gecko/taskcluster/scripts/phone-builder && buildbot_step 'Build' ./build-phone.sh $HOME/workspace"]

Ah now that should work!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0eaec57731b7
Fix task definition by forcing /bin/bash r=garndt

Comment 8

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6848d6a08ff9

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/0eaec57731b7