Closed Bug 1283452 Opened 4 years ago Closed 4 years ago

Fix b2g phone task definition

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file)

No description provided.
https://reviewboard.mozilla.org/r/61530/#review58392

::: taskcluster/ci/legacy/tasks/builds/b2g_aries_spark_debug.yml:27
(Diff revision 1)
>        GAIA_OPTIMIZE: '1'
>        B2G_SYSTEM_APPS: '1'
>        MOZHARNESS_CONFIG: b2g/taskcluster-spark.py
>      command:
>        - >
> -        checkout-gecko workspace &&
> +        /bin/bash -c "checkout-gecko workspace &&

Hrm, I'm not sure off hand how this would behave when declared like this (a push to try would clear that up quickly though)

Typically we've done something like this:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/tasks/builds/base_linux64.yml#33
Comment on attachment 8766764 [details]
Bug 1283452 - Fix task definition by forcing /bin/bash

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61530/diff/1-2/
Comment on attachment 8766764 [details]
Bug 1283452 - Fix task definition by forcing /bin/bash

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61530/diff/2-3/
Comment on attachment 8766764 [details]
Bug 1283452 - Fix task definition by forcing /bin/bash

https://reviewboard.mozilla.org/r/61530/#review58526

::: taskcluster/ci/legacy/tasks/builds/b2g_aries_spark_debug.yml:25
(Diff revisions 2 - 3)
>        DEBUG: 0
>        VARIANT: userdebug
>        GAIA_OPTIMIZE: '1'
>        B2G_SYSTEM_APPS: '1'
>        MOZHARNESS_CONFIG: b2g/taskcluster-spark.py
> -    command:
> +    command: ["/bin/bash", "-c", "checkout-gecko workspace && cd ./workspace/gecko/taskcluster/scripts/phone-builder && buildbot_step 'Build' ./build-phone.sh $HOME/workspace"]

Ah now that should work!
Attachment #8766764 - Flags: review?(garndt) → review+
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0eaec57731b7
Fix task definition by forcing /bin/bash r=garndt
https://hg.mozilla.org/mozilla-central/rev/0eaec57731b7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.