bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Update username event from panel should spread to the stores

RESOLVED FIXED

Status

Hello (Loop)
Client
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fcampo, Assigned: andreio)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
From bug 1279042 comment 4

We already show the username from localStorage as user identity [bug 1279042], but when user changes its username from the panel, the event does not reach the stores, so the new name it's not shown on chat/presence.

Possible implementation mentioned on bug 1279042 comment 3

Updated

2 years ago
Blocks: 1283558
(Assignee)

Updated

2 years ago
QA Contact: andrei.br92
Created attachment 8768276 [details] [review]
[loop] piatra:1283457-update-username > mozilla:akita
(Assignee)

Updated

2 years ago
Assignee: nobody → andrei.br92
(Assignee)

Updated

2 years ago
QA Contact: andrei.br92
(Assignee)

Updated

2 years ago
Attachment #8768276 - Flags: review?(standard8)
Attachment #8768276 - Flags: review?(fernando.campo)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8768276 [details] [review]
[loop] piatra:1283457-update-username > mozilla:akita

Left some comments on GH. It looks good, but we need to subscribe from ParticipantStore too so presence is updated.

Please ask for review when changes are done.
Attachment #8768276 - Flags: review?(fernando.campo)
Attachment #8768276 - Flags: review?(standard8)
(Reporter)

Comment 3

2 years ago
Comment on attachment 8768276 [details] [review]
[loop] piatra:1283457-update-username > mozilla:akita

code looks good, just need to add an updateRoomInfo call so the name change is reflected on the presence indicator for the rest of the connected peers (and a test for it, please)
Attachment #8768276 - Flags: review+
(Assignee)

Comment 4

2 years ago
https://github.com/mozilla/loop/pull/559
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.