1283459 - Rename pacUrl to proxyAutoconfigUrl

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Selenium implementations use proxyAutoconfigUrl already and https://github.com/w3c/webdriver/pull/311 is suggesting standardising pacUrl.  We should change to use what existing drivers are doing so we don’t have to manage compatibility in this area.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1283459 - Rename pacUrl to proxyAutoconfigUrl;

In order to not have to manage compatibility in this area, we use the
field name proxyAutoconfigUrl that existing Selenium implementations use.

Review commit: https://reviewboard.mozilla.org/r/61534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61534/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8766767 [details]
Bug 1283459 - Rename pacUrl to proxyAutoconfigUrl;

https://reviewboard.mozilla.org/r/61534/#review58494

Comment 3

[Jason Juang (:juangj)]

Do you know which version of FF we could expect this in?

We could just change local ends to set both pacUrl and proxyAutoconfigUrl capabilities in the interim, I suppose.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8b3b1c92085
Rename pacUrl to proxyAutoconfigUrl; r=automatedtester

Comment 5

[Andreas Tolfsen ❲:ato❳]

juangj: I’ve just landed it on inbound, which means it will be available in Firefox 50.  But I suspect we can request this patch to be uplifted all the way to Firefox 48.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/b8b3b1c92085

Comment 7

[Andreas Tolfsen ❲:ato❳]

It would be good to uplift this to Aurora and Beta for greater WebDriver conformance.

Comment 8

[Carsten Book [:Tomcat]]

 https://hg.mozilla.org/releases/mozilla-aurora/rev/5e44121bee42
https://hg.mozilla.org/releases/mozilla-beta/rev/ade7d8506f42

done :)