Closed Bug 1283459 Opened 3 years ago Closed 3 years ago

Rename pacUrl to proxyAutoconfigUrl

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

Selenium implementations use proxyAutoconfigUrl already and https://github.com/w3c/webdriver/pull/311 is suggesting standardising pacUrl.  We should change to use what existing drivers are doing so we don’t have to manage compatibility in this area.
Assignee: nobody → ato
Status: NEW → ASSIGNED
In order to not have to manage compatibility in this area, we use the
field name proxyAutoconfigUrl that existing Selenium implementations use.

Review commit: https://reviewboard.mozilla.org/r/61534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61534/
Attachment #8766767 - Flags: review?(dburns)
Comment on attachment 8766767 [details]
Bug 1283459 - Rename pacUrl to proxyAutoconfigUrl;

https://reviewboard.mozilla.org/r/61534/#review58494
Attachment #8766767 - Flags: review?(dburns) → review+
Do you know which version of FF we could expect this in?

We could just change local ends to set both pacUrl and proxyAutoconfigUrl capabilities in the interim, I suppose.
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8b3b1c92085
Rename pacUrl to proxyAutoconfigUrl; r=automatedtester
juangj: I’ve just landed it on inbound, which means it will be available in Firefox 50.  But I suspect we can request this patch to be uplifted all the way to Firefox 48.
https://hg.mozilla.org/mozilla-central/rev/b8b3b1c92085
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
It would be good to uplift this to Aurora and Beta for greater WebDriver conformance.
Whiteboard: [checkin-needed-aurora] [checkin-needed-beta]
Whiteboard: [checkin-needed-aurora] [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.