128347 - modutil -add does not allow a parameter string to be passed

Status: VERIFIED FIXED

(NSS :: Tools, enhancement, P2)

Description

[Julien Pierre]

Since NSS has the ability to pass a parameter string to a PKCS#11 module's
C_Initialize function, we should be able to pass such a string when adding a
module to secmod.db, so that any application initializing NSS could load those
modules that require a configuration string. An extra parameter should be used,
eg -string <paramstring> .

Comment 1

[Julien Pierre]

Taking bug.

Comment 2

[Julien Pierre]

Dumb back button in Netscape6.
So, again, taking bug.

Comment 3

[Julien Pierre]

We need a new SECMOD_AddNewModuleEx call to implement this. Adding dependency on
128355.

Comment 4

[Julien Pierre]

Attachment: Patch to add -string option to modutil and use the new SECMOD_AddNewModuleEx

Comment 5

[Julien Pierre]

Bob or Ian,

Please review. I tested this patch and it works after the patch from 128355.

Comment 6

[Robert Relyea]

Comment on attachment 71968 [details] [diff] [review]
Patch to add -string option to modutil and use the new SECMOD_AddNewModuleEx

Nit: try to make sure you are using the NSS standard whitespace: 
indent 4 each time, tabstop at 8:
....
|-tab--|
|-tab--|....
|-tab--||-tab--|

etc
where . = space and
|-tab--| = tab

(that is way lines 145 and 240 don't line up in the context diff)

Comment 7

[Robert Relyea]

oops I forget: r=relyea

Comment 8

[Julien Pierre]

I think we should have a CVS filter that rejects all check-ins with TAB
characters in them. May the tab characters die !
OK, I fixed the identation.

Checking in modutil.c;
/cvsroot/mozilla/security/nss/cmd/modutil/modutil.c,v  <--  modutil.c
new revision: 1.13; previous revision: 1.12
done
Checking in modutil.h;
/cvsroot/mozilla/security/nss/cmd/modutil/modutil.h,v  <--  modutil.h
new revision: 1.3; previous revision: 1.2
done
Checking in pk11.c;
/cvsroot/mozilla/security/nss/cmd/modutil/pk11.c,v  <--  pk11.c
new revision: 1.13; previous revision: 1.12
done

Comment 9

[Julien Pierre]

verified