1283478 - Tapping the download notification does not open the downloaded file

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open Firefox and perform a download
2. Open the notification bar and tap on the download complete notification.

Expected results:
- The file is opened and displayed correctly.

Actual results:
- Nothing happens.

Note:
- regression:
good build:
bad build:
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0e073f5ca38a002d43e92016ee40d686da4a0534&tochange=c2da34d96746288b5fee27bf6542a12c9f410988

Bug 1075476 - Removing download notification restart

Comment 1

[Jonathan Almeida [:jonalmeida]]

I started looking into this yesterday. I'll investigate into this today and see how bug 1075476 caused this.

Comment 2

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1283478 - Tapping the download notification does not open the downloaded file

We were incorrectly retrieving the cookie from the notification intent
and passing that along which affected the invocation of the notification.

Review commit: https://reviewboard.mozilla.org/r/62552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62552/

Comment 3

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 8768220 [details]
Bug 1283478 - Tapping the download notification does not open the downloaded file

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62552/diff/1-2/

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8768220 [details]
Bug 1283478 - Tapping the download notification does not open the downloaded file

https://reviewboard.mozilla.org/r/62552/#review60466

I didn't verify myself that it fixes the issue but it looks like [the original change](https://hg.mozilla.org/mozilla-central/rev/3a6ed18fa2a9#l3.97) so wfm.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/668bade89622
Tapping the download notification does not open the downloaded file r=mcomella

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/668bade89622

Comment 7

[Teodora Vermesan (:TeoVermesan)]

Tapping the download notification will open and display correctly the file, so:
Verified as fixed using:
Device: One A2001 (Android 5.1.1)
Build: Firefox for Android 50.0a1 (2016-07-28)