1283528 - "ASSERTION: nsITimer->SetDelay() called when the one-shot timer is not set up" cleaning up WebGLContext during shutdown CC

Status: RESOLVED INCOMPLETE

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: nsITimer->SetDelay() called when the one-shot timer is not set up.: 'Error', file xpcom/threads/nsTimerImpl.cpp, line 375

> #01: mozilla::WebGLContext::~WebGLContext() [mfbt/RefPtr.h:61]
> #02: mozilla::WebGL1Context::~WebGL1Context() [memory/mozalloc/mozalloc.h:217]
> #03: SnowWhiteKiller::~SnowWhiteKiller() [xpcom/base/nsCycleCollector.cpp:2685]
> #04: nsCycleCollector::FreeSnowWhite(bool) [xpcom/base/nsCycleCollector.cpp:2678]
> #05: nsCycleCollector::BeginCollection(ccType, nsICycleCollectorListener*) [mfbt/RefPtr.h:289]
> #06: nsCycleCollector::Collect(ccType, js::SliceBudget&, nsICycleCollectorListener*, bool) [xpcom/base/nsCycleCollector.cpp:3666]
> #07: nsCycleCollector::ShutdownCollect() [xpcom/base/nsCycleCollector.cpp:3607]
> #08: nsCycleCollector_shutdown() [mfbt/RefPtr.h:61]
> #09: mozilla::ShutdownXPCOM(nsIServiceManager*) [xpcom/build/XPCOMInit.cpp:968]
> #10: ScopedXPCOMStartup::~ScopedXPCOMStartup() [toolkit/xre/nsAppRunner.cpp:1489]
> #11: XREMain::XRE_main(int, char**, nsXREAppData const*) [memory/mozalloc/mozalloc.h:217]
> #12: XRE_main [toolkit/xre/nsAppRunner.cpp:4599]
> #13: main [browser/app/nsBrowserApp.cpp:254]

Comment 1

[Jesse Ruderman]

Strangely, this reproduces reliably with "debug+opt" builds such as https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-macosx64-debug/1467287427/ but not at all with local debug builds.

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

The patch at https://bugzilla.mozilla.org/show_bug.cgi?id=1280507#c14 remove the crash "nsITimer->SetDelay()" call.
Jesse, Maybe you could try again after it merged to m-c.