Created attachment 8766859 [details] [diff] [review] Remove obsolete code bsmedberg, mind take a look at this? This code is obsolete now, and I want to remove the version checks from nsCocoaFeatures.h in bug 1282251.
Attachment #8766859 - Flags: review?(benjamin)
Priority: -- → P3
Comment on attachment 8766859 [details] [diff] [review] Remove obsolete code >diff --git a/dom/plugins/ipc/PluginInstanceChild.cpp b/dom/plugins/ipc/PluginInstanceChild.cpp >- bool avoidCGCrashes = !nsCocoaFeatures::OnMountainLionOrLater() && >- (GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES); >+ bool avoidCGCrashes = GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES; This logic looks wrong. The avoidCGCrashes quirk was only for old versions of MacOS, so avoidCGCrashes should always be false now (and we could remove the quirk code entirely.
Attachment #8766859 - Flags: review?(benjamin) → review-
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2) > and we could remove the quirk code entirely. Mind having a separate bug for that?
I don't particularly care.
Created attachment 8768457 [details] [diff] [review] Now with correct logic Not sure how I missed this... I'll file a bug for the quirk code removal.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/098b3b8860dc Remove obsolete OS X version checks in ipc/glue and dom/plugins/ipc. r=bsmedberg.
Filed bug 1284939 for the quirk code removal.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.