Remove obsolete OS X version checks in ipc/glue and dom/plugins/ipc

RESOLVED FIXED in Firefox 50

Status

()

P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
mozilla50
Unspecified
macOS
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8766859 [details] [diff] [review]
Remove obsolete code

bsmedberg, mind take a look at this? This code is obsolete now, and I want to remove the version checks from nsCocoaFeatures.h in bug 1282251.
Attachment #8766859 - Flags: review?(benjamin)

Comment 2

3 years ago
Comment on attachment 8766859 [details] [diff] [review]
Remove obsolete code

>diff --git a/dom/plugins/ipc/PluginInstanceChild.cpp b/dom/plugins/ipc/PluginInstanceChild.cpp

>-                bool avoidCGCrashes = !nsCocoaFeatures::OnMountainLionOrLater() &&
>-                  (GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES);
>+                bool avoidCGCrashes = GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES;

This logic looks wrong. The avoidCGCrashes quirk was only for old versions of MacOS, so avoidCGCrashes should always be false now (and we could remove the quirk code entirely.
Attachment #8766859 - Flags: review?(benjamin) → review-
(Assignee)

Comment 3

3 years ago
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)

> and we could remove the quirk code entirely.

Mind having a separate bug for that?

Comment 4

3 years ago
I don't particularly care.
(Assignee)

Comment 5

3 years ago
Created attachment 8768457 [details] [diff] [review]
Now with correct logic

Not sure how I missed this... I'll file a bug for the quirk code removal.
Attachment #8766859 - Attachment is obsolete: true
Attachment #8768457 - Flags: review?(benjamin)

Updated

3 years ago
Attachment #8768457 - Flags: review?(benjamin) → review+

Comment 6

3 years ago
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/098b3b8860dc
Remove obsolete OS X version checks in ipc/glue and dom/plugins/ipc. r=bsmedberg.
(Assignee)

Comment 7

3 years ago
Filed bug 1284939 for the quirk code removal.

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/098b3b8860dc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.