1283559 - Remove obsolete OS X version checks in ipc/glue and dom/plugins/ipc

Status: RESOLVED FIXED

(Core :: IPC, defect, P3)

Comment 1

[Stefan [:stefanh]]

Attachment: Remove obsolete code

bsmedberg, mind take a look at this? This code is obsolete now, and I want to remove the version checks from nsCocoaFeatures.h in bug 1282251.

Comment 2

[Benjamin Smedberg]

Comment on attachment 8766859 [details] [diff] [review]
Remove obsolete code

>diff --git a/dom/plugins/ipc/PluginInstanceChild.cpp b/dom/plugins/ipc/PluginInstanceChild.cpp

>-                bool avoidCGCrashes = !nsCocoaFeatures::OnMountainLionOrLater() &&
>-                  (GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES);
>+                bool avoidCGCrashes = GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES;

This logic looks wrong. The avoidCGCrashes quirk was only for old versions of MacOS, so avoidCGCrashes should always be false now (and we could remove the quirk code entirely.

Comment 3

[Stefan [:stefanh]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)

> and we could remove the quirk code entirely.

Mind having a separate bug for that?

Comment 4

[Benjamin Smedberg]

I don't particularly care.

Comment 5

[Stefan [:stefanh]]

Attachment: Now with correct logic

Not sure how I missed this... I'll file a bug for the quirk code removal.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/098b3b8860dc
Remove obsolete OS X version checks in ipc/glue and dom/plugins/ipc. r=bsmedberg.

Comment 7

[Stefan [:stefanh]]

Filed bug 1284939 for the quirk code removal.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/098b3b8860dc