Closed
Bug 1283594
Opened 8 years ago
Closed 8 years ago
CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
This is bad because we're not 100% if we forgot to report a failure or we succeeded.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61622/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61622/
Attachment #8766905 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → bgirard
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8766905 [details] Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string. https://reviewboard.mozilla.org/r/61622/#review58466 I think we want to lift this out so that it more accurately represents reality and not just the block list.
Attachment #8766905 -
Flags: review?(jmuizelaar) → review-
|
|
Assignee | |
Comment 3•8 years ago
|
||
We're going to block this on having bug 1271770 because it's going to change how we fallback which will conflict heavily with the approach we decide to take here.
Blocks: 1271770
|
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8766905 [details] Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61622/diff/1-2/
Attachment #8766905 -
Flags: review- → review?(jmuizelaar)
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e091b5f5ce9
|
|
||
Updated•8 years ago
|
Attachment #8766905 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8766905 [details] Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string. https://reviewboard.mozilla.org/r/61622/#review62934
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(bgirard)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8766905 [details] Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61622/diff/2-3/
Pushed by b56girard@gmail.com: https://hg.mozilla.org/integration/autoland/rev/37e77c6f0409 CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string. r=jrmuizel
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/37e77c6f0409
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(bgirard)
You need to log in
before you can comment on or make changes to this bug.
Description
•