Closed Bug 1283594 Opened 7 years ago Closed 7 years ago

CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file)

Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string.
58 bytes, text/x-review-board-request
jrmuizel
: review+
Details 
This is bad because we're not 100% if we forgot to report a failure or we succeeded.
Assignee: nobody → bgirard
Comment on attachment 8766905 [details]
Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string.

https://reviewboard.mozilla.org/r/61622/#review58466

I think we want to lift this out so that it more accurately represents reality and not just the block list.
Attachment #8766905 - Flags: review?(jmuizelaar) → review-
We're going to block this on having bug 1271770 because it's going to change how we fallback which will conflict heavily with the approach we decide to take here.
Blocks: 1271770
No longer blocks: 1271770
Depends on: 1271770
Comment on attachment 8766905 [details]
Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61622/diff/1-2/
Attachment #8766905 - Flags: review- → review?(jmuizelaar)
Attachment #8766905 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8766905 [details]
Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string.

https://reviewboard.mozilla.org/r/61622/#review62934
Flags: needinfo?(bgirard)
Comment on attachment 8766905 [details]
Bug 1283594 - CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61622/diff/2-3/
Pushed by b56girard@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/37e77c6f0409
CANVAS_WEBGL_ACCL_FAILURE_ID reports success as empty string. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/37e77c6f0409
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Flags: needinfo?(bgirard)
You need to log in before you can comment on or make changes to this bug.