1283667 - Occasionally getting HTTP 500 responses when trying to create/verify test FxA users

Status: RESOLVED WORKSFORME

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Lately, we've been seeing what appear to be (from our stacktraces) HTTP 500 errors emanating from this code block:

https://github.com/mozilla/Addon-Tests/blob/0425100fe4671e87b32e48249365225f836c40c9/tests/conftest.py#L58-L66

Specifically, line 66 (https://github.com/mozilla/Addon-Tests/blob/0425100fe4671e87b32e48249365225f836c40c9/tests/conftest.py#L66), there, propagates what our Python "requests" library returns from the server (HTTP 500), like so:

15:16:32 ==================================== ERRORS ====================================
15:16:32 ________ ERROR at setup of TestCollections.test_user_my_favorites_page _________
15:16:32 [gw2] linux2 -- Python 2.7.9 /var/lib/jenkins/jobs/amo.stage.saucelabs/workspace/.venv/bin/python2.7
15:16:32 tests/conftest.py:66: in user
15:16:32     assert requests.codes.created == r.status_code
15:16:32 E   assert 201 == 500
15:16:32 E    +  where 201 = 201
15:16:32 E    +    where 201 = <lookup 'status_codes'>.created
15:16:32 E    +      where <lookup 'status_codes'> = <lookup 'status_codes'>
15:16:32 E    +        where <lookup 'status_codes'> = requests.codes
15:16:32 E    +  and   500 = 500
15:16:32 E    +    where 500 = <Response [500]>.status_code
15:16:32 ---------------------------- Captured stdout setup -----------------------------
15:16:32 fxapom created an account for email: [e-mail] at https://api.accounts.firefox.com/ on 2016-06-30 22:11:29.852910
15:16:32 ------------------------------- pytest-selenium --------------------------------
15:16:32 URL: about:blank
15:16:32 SauceLabs Job: http://saucelabs.com/jobs/2dd5bacda1fa4cceac7de5ac689a93e2

I can't readily tell (sorry, not 100% familiar with this part of our codebase) if that's from the AMO staging server or restmail or api.accounts.firefox.com, really :-(

Some builds where I've seen it:

https://webqa-ci.mozilla.com/view/AMO/job/amo.stage.saucelabs/1057/console
https://webqa-ci.mozilla.com/view/AMO/job/amo.stage.saucelabs/1060/console
https://webqa-ci.mozilla.com/view/AMO/job/amo.stage.saucelabs/1061/console

Comment 1

[Ryan Kelly [:rfkelly]]

My initial read of the code, is that this 500 is coming from the addons server when you make the "super-create" call described here:

  http://addons-server.readthedocs.io/en/latest/topics/api/accounts.html#super-creation

It doesn't appear to coming directly from FxA.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Ryan Kelly [:rfkelly] from comment #1)
> My initial read of the code, is that this 500 is coming from the addons
> server when you make the "super-create" call described here:
> 
>  
> http://addons-server.readthedocs.io/en/latest/topics/api/accounts.html#super-
> creation
> 
> It doesn't appear to coming directly from FxA.

Yeah, thanks; Krupa, we should punt this over to the Add-ons team, but they only use GitHub for issues, right?

Comment 3

[krupa raj [:krupa--use this to needinfo]]

(In reply to Stephen Donner [:stephend] from comment #2)
> (In reply to Ryan Kelly [:rfkelly] from comment #1)
> > My initial read of the code, is that this 500 is coming from the addons
> > server when you make the "super-create" call described here:
> > 
> >  
> > http://addons-server.readthedocs.io/en/latest/topics/api/accounts.html#super-
> > creation
> > 
> > It doesn't appear to coming directly from FxA.
> 
> Yeah, thanks; Krupa, we should punt this over to the Add-ons team, but they
> only use GitHub for issues, right?

yes, the issue can be filed at https://github.com/mozilla/addons-server/issues/new

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks, Krupa.  Closing this as 1) can't currently reproduce it 2) the GitHub Issue tracker is the place to file, as you mention, when we set it again.