128367 - Save button and menu command silently fails to save to write-protected file.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[William Cattey]

I was editing an HTML file in Composer that happened to be under RCS.
I'd forgotten to check the file out, so it was write protected.

Through my whole editing session I'd been pressing the save button
and watching it grey-out indicative of success.

When none of my changes had actually made it into the file, I investigated.

Apparently using the save button on a write-protected file PRETENDS to 
succeed.

Using the Save As... command correctly recognized that the file was
write protected.  Both the button and the menu command for Save
gave NO INDICATION WHATSOEVER that the save had failed.

This is with the Composer that shipped with Mozilla 0.9.8 talkback release
ID 2002020415.

Comment 1

[michael wendell]

I am seeing this problem on Win 98 using the 03-01 trunk build.  

Confirming.

Comment 2

[michael wendell]

Reassigning to brade and ccing cmanske per Sujay's request.

Comment 3

[William Cattey]

The following may also be related to the same block of code:

ANY save silently thinks it succeeded if you happen to overrun your
disk quota. I got NO indication that large PDF files I was saving
were not being saved owing to my having no disk quota.

SOMEBODY is not testing for enough error return statuses on save.
The over-quota is happening in the browser, I'm reasonably sure it
will be happening in Composer too.

Do y'all want to keep the quota silent failure in this bug, or should
I open a new one?

Comment 4

[Charles Manske]

This is one of the conditions Bill told me about that nsIWebBrowserPersist
error handling fails to detect. Reassign to him?

Comment 5

[Bill Law]

No, I've given that bug over to Adam Lock.

Comment 6

[Kathleen :Brade]

Attachment: minimum patch (for 0.9.9?)

This patch ensures that persist code passes on any errors encountered when
saving.  With this patch, the UI will not act like it successfully saved
however, there isn't any dialog (that will be in a separate patch/attachment).

Comment 7

[Adam Lock]

Comment on attachment 72786 [details] [diff] [review]
minimum patch (for 0.9.9?)

r=adamlock

Comment 8

[Kathleen :Brade]

Attachment: Composer portion of fix; if saving failed we should tell user (not just when error thrown)

This fix is for Composer only.	Composer was only displaying error messages
when errors were thrown and not when the save failed by returning an error. 
This fix moves the dialog out of the catch.

Comment 9

[Adam Lock]

Comment on attachment 72789 [details] [diff] [review]
Composer portion of fix; if saving failed we should tell user (not just when error thrown)

r=adamlock

Comment 10

[Kathleen :Brade]

Attachment: same patch for Composer but with more context

more context in this version; easier to understand what's going on

Comment 11

[kinmoz]

Comment on attachment 72786 [details] [diff] [review]
minimum patch (for 0.9.9?)

sr=[e-mail]

Comment 12

[kinmoz]

Comment on attachment 72789 [details] [diff] [review]
Composer portion of fix; if saving failed we should tell user (not just when error thrown)

sr=[e-mail]

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 72786 [details] [diff] [review]
minimum patch (for 0.9.9?)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 72789 [details] [diff] [review]
Composer portion of fix; if saving failed we should tell user (not just when error thrown)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 15

[Kathleen :Brade]

fix checked into 1.0 trunk

Comment 16

[Kathleen :Brade]

*** Bug 131108 has been marked as a duplicate of this bug. ***

Comment 17

[michael wendell]

Verified on Win Xp using the 04-30 trunk build.

I now receive a message that says "Saving file failed"

Marking VERIFIED.

If anyone is still able to reproduce this problem, feel free to reopen this bug.

Comment 18

[Adrian Ulrich]

*** Bug 144697 has been marked as a duplicate of this bug. ***