1283699 - Intermittent devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Treeherder Bug Filer]

Filed by: [e-mail]

https://treeherder.mozilla.org/logviewer.html#?job_id=31019327&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux64-pgo/1467318683/mozilla-inbound_ubuntu64_vm_test_pgo-mochitest-e10s-devtools-chrome-5-bm113-tests1-linux64-build0.txt.gz

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Looks like this is timing out right as it is finishing. Both TEST-UNEXPECTED-FAIL from the timeout and TEST-OK happen at 16:49:06. What is the default timeout these days? 70-80s?

> 16:49:06     INFO -  267 INFO Closing memory panel.
> 16:49:06     INFO -  268 INFO Console message: [JavaScript Warning: "Error in parsing value for ‘height’.  Declaration dropped." {file: "chrome://devtools/content/memory/memory.xhtml" line: 0 column: 26 source: "padding:0;margin:0;height:-234px;"}]
> 16:49:06     INFO -  269 INFO Console message: [JavaScript Warning: "Error in parsing value for ‘height’.  Declaration dropped." {file: "chrome://devtools/content/memory/memory.xhtml" line: 0 column: 0 source: "-198px"}]
> 16:49:06     INFO -  270 INFO Closed memory panel successfully.
> 16:49:06     INFO -  271 INFO Removing tab.
> 16:49:06     INFO -  272 INFO Waiting for event: 'TabClose' on [object XULElement].
> 16:49:06     INFO -  273 INFO Got event: 'TabClose' on [object XULElement].
> 16:49:06     INFO -  274 INFO Tab removed and finished closing
> 16:49:06     INFO -  275 INFO TEST-UNEXPECTED-FAIL | devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
> 16:49:06     INFO -  MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
> 16:49:06     INFO -  MEMORY STAT | vsize 1172MB | residentFast 282MB | heapAllocated 117MB
> 16:49:06     INFO -  276 INFO TEST-OK | devtools/client/memory/test/browser/browser_memory_allocationStackDisplay_01.js | took 79904ms

Comment 2

[Brian Grinstead [:bgrins]]

Looks like 45 seconds: https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/_tests/testing/mochitest/mochijar/chrome/mochikit/content/browser-test.js#3

Comment 3

[Brian Grinstead [:bgrins]]

Oh, but that can be overridden: https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#1638 so looks like maybe 60 seconds: https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#1532.  And maybe setup / teardown is included in the time reported here (just guessing)

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: memory-panel-intermittents.patch

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d424c938d357

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/mozilla-central/rev/5d16dca06481