Closed
Bug 1283705
Opened 8 years ago
Closed 6 years ago
Intermittent devtools/client/shared/test/browser_tableWidget_mouse_interaction.js | Test timed out -
Categories
(DevTools :: Shared Components, defect, P3)
DevTools
Shared Components
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: intermittent-bug-filer, Unassigned)
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
58 bytes,
text/x-review-board-request
|
miker
:
review+
|
Details |
8.69 KB,
patch
|
Details | Diff | Splinter Review |
Updated•8 years ago
|
Component: Developer Tools → Developer Tools: Shared Components
Comment 1•8 years ago
|
||
Can reproduce locally by slowing down my machine. The test is blocked while waiting for a popup that never appears.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/64554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64554/
Attachment #8771330 -
Flags: review?(mratcliffe)
Comment 3•8 years ago
|
||
Waiting for popuphidden when needed seems to fix the intermittent timeouts for me. Will push to try when trees reopen.
Comment hidden (Intermittent Failures Robot) |
Comment 5•8 years ago
|
||
Comment 6•8 years ago
|
||
try is green except for unrelated intermittents.
Attachment #8771330 -
Flags: review?(mratcliffe) → review+
Comment on attachment 8771330 [details]
Bug 1283705 - wait for popuphidden to fix intermittent test browser_tableWidget_mouse_interaction;
https://reviewboard.mozilla.org/r/64554/#review63192
An easy r+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/ff29f08b72c4
wait for popuphidden to fix intermittent test browser_tableWidget_mouse_interaction;r=miker
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 11•8 years ago
|
||
Waiting for the popuphidden event is not enough here, there are still regular failures on Linux pgo. On Linux it looks like the xul <menupopup> fades before being completely hidden. This is driven by the OS and not taken into account by the "popuphidden" event.
The test already waits before triggering the click events using executeSoon. I don't think we can use any event here to know when the menu is actually hidden by the OS, so I would be in favor of waiting more before clicking.
Adding leave-open until I have a proper fix.
Keywords: leave-open
Comment 12•8 years ago
|
||
bugherder |
Comment 13•8 years ago
|
||
Not sure my try run will successfully run pgo jobs -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e569dfa0ce843bfff1678d9b65bbd2e564e56763
In the meantime I am attaching my current patch here. I'll be off between the 27th of July and the 3rd of August, so if anyone wants to pick the bug in the meantime, feel free to take it.
Comment 14•8 years ago
|
||
Unassigning myself while I am away. Will check back.
Assignee: jdescottes → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jdescottes)
Comment 16•8 years ago
|
||
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 17•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:Honza, maybe it's time to close this bug?
Flags: needinfo?(odvarko)
Comment 18•6 years ago
|
||
(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #17)
The leave-open keyword is there and there is no activity for 6 months.
:Honza, maybe it's time to close this bug?
Agree, closing this report
Honza
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(odvarko)
Resolution: --- → WORKSFORME
Updated•6 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•