58 bytes, text/x-review-board-request
On Hello's functional tests for latest nightly, we're seeing: File "/home/worker/repo/.venv/local/lib/python2.7/site-packages/marionette/runtests.py", line 67, in run runner.run_tests(tests) File "/home/worker/repo/.venv/local/lib/python2.7/site-packages/marionette/runner/base.py", line 764, in run_tests if self.capabilities['device'] == "desktop": KeyError: 'device' This seems to be because the in-Firefox part was updated but the version of PyPI hasn't been. Please could we have a new release? Side note: Is it worth thinking about backwards-compat at some stage in the future so that different versions in PyPI are still compatible with different versions of Firefox (i.e. the ones in the current release train).
Created attachment 8767668 [details] Bug 1283745: Update marionette harness version to 3.1.0 This change allows Marionette harness to work with the Nightly which no longer has the `device` capability. It was removed in Bug 1282800. Review commit: https://reviewboard.mozilla.org/r/62106/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62106/
Attachment #8767668 - Flags: review?(ato)
Comment on attachment 8767668 [details] Bug 1283745: Update marionette harness version to 3.1.0 https://reviewboard.mozilla.org/r/62106/#review58824
Attachment #8767668 - Flags: review?(ato) → review+
Did we had any other driver changes in the last month which would make sense to also release at the same time?
(In reply to Henrik Skupin (:whimboo) from comment #4) > Did we had any other driver changes in the last month which would make sense > to also release at the same time? Looking at the log I am not sure it warrants a release of the driver code as its linting and fixes that help people working in tree.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/93cc9bcee8c8 Update marionette harness version to 3.1.0 r=ato
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
pushed to pypi hard linking marionette_client.egg-info/requires.txt -> marionette_client-3.1.0/marionette_client.egg-info hard linking marionette_client.egg-info/top_level.txt -> marionette_client-3.1.0/marionette_client.egg-info hard linking session/__init__.py -> marionette_client-3.1.0/session hard linking session/runtests.py -> marionette_client-3.1.0/session hard linking session/session_test.py -> marionette_client-3.1.0/session hard linking session/runner/__init__.py -> marionette_client-3.1.0/session/runner hard linking session/runner/base.py -> marionette_client-3.1.0/session/runner Writing marionette_client-3.1.0/setup.cfg creating dist Creating tar archive removing 'marionette_client-3.1.0' (and everything under it) running upload Submitting dist/marionette_client-3.1.0.tar.gz to https://pypi.python.org/pypi Server response (200): OK copying build/lib/session/runner/base.py -> build/bdist.macosx-10.11-x86_64/wheel/session/runner copying build/lib/session/runtests.py -> build/bdist.macosx-10.11-x86_64/wheel/session copying build/lib/session/session_test.py -> build/bdist.macosx-10.11-x86_64/wheel/session running install_egg_info Copying marionette_client.egg-info to build/bdist.macosx-10.11-x86_64/wheel/marionette_client-3.1.0-py2.7.egg-info running install_scripts creating build/bdist.macosx-10.11-x86_64/wheel/marionette_client-3.1.0.dist-info/WHEEL running upload Submitting /Users/dburns/development/mozilla-central/testing/marionette/harness/dist/marionette_client-3.1.0-py2-none-any.whl to https://pypi.python.org/pypi Server response (200): OK
You need to log in before you can comment on or make changes to this bug.