1283759 - Pass securityFlag to newChannel for packaged_app tests

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb]]

TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_service.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_service_paths.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_bug1214079.js | xpcshell return code: 0

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1283759_securityflag_packaged_app_tests.patch

Hey Valentin, when working on Bug 1283427 I realized we are not explicitly passing security flags for the 3 packaged_app tests. SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL is the least restrictive flag so is the appropriate one to use for those tests.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8767066 [details] [diff] [review]
bug_1283759_securityflag_packaged_app_tests.patch

Review of attachment 8767066 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/733e6ac3ee54
Pass securityFlag to newChannel for packaged_app tests r=valentin

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/733e6ac3ee54