Pass securityFlag to newChannel for packaged_app tests

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_service.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_service_paths.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_bug1214079.js | xpcshell return code: 0
(Assignee)

Updated

2 years ago
Assignee: nobody → ckerschb
Blocks: 1182535
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
(Assignee)

Comment 1

2 years ago
Created attachment 8767066 [details] [diff] [review]
bug_1283759_securityflag_packaged_app_tests.patch

Hey Valentin, when working on Bug 1283427 I realized we are not explicitly passing security flags for the 3 packaged_app tests. SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL is the least restrictive flag so is the appropriate one to use for those tests.
Attachment #8767066 - Flags: review?(valentin.gosu)
Comment on attachment 8767066 [details] [diff] [review]
bug_1283759_securityflag_packaged_app_tests.patch

Review of attachment 8767066 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8767066 - Flags: review?(valentin.gosu) → review+

Comment 3

2 years ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/733e6ac3ee54
Pass securityFlag to newChannel for packaged_app tests r=valentin

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/733e6ac3ee54
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.