Closed
Bug 1283759
Opened 8 years ago
Closed 8 years ago
Pass securityFlag to newChannel for packaged_app tests
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
|
3.14 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_service.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_service_paths.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_packaged_app_bug1214079.js | xpcshell return code: 0
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Hey Valentin, when working on Bug 1283427 I realized we are not explicitly passing security flags for the 3 packaged_app tests. SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL is the least restrictive flag so is the appropriate one to use for those tests.
Attachment #8767066 -
Flags: review?(valentin.gosu)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8767066 [details] [diff] [review] bug_1283759_securityflag_packaged_app_tests.patch Review of attachment 8767066 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8767066 -
Flags: review?(valentin.gosu) → review+
Pushed by mozilla@christophkerschbaumer.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/733e6ac3ee54 Pass securityFlag to newChannel for packaged_app tests r=valentin
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/733e6ac3ee54
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•