1283763 - fix gdb pretty printers for nsTArray

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

For types like "nsTArray<nsCOMPtr<nsIInputStream>>", the pretty printer will first match "nsCOMPtr", then throws exception because there is no "mRawPtr".

Comment 1

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Attachment: Bug 1283763 - Fix gdb pretty printers for nsTArray.

Review commit: https://reviewboard.mozilla.org/r/61776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61776/

Comment 2

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Not work for "mozilla::AlignedStorage2<nsTArray<mozilla::ipc::FileDescriptor> >".
Maybe needs some try-catch.

Comment 3

[Trevor Saunders (:tbsaunde)]

(In reply to Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] from comment #2)
> Not work for
> "mozilla::AlignedStorage2<nsTArray<mozilla::ipc::FileDescriptor> >".
> Maybe needs some try-catch.

It seems like there's a general problem here that the pretty printers will match basically anything containing nsTArray / nsCOMPtr / whatever, that's because the regexps are pretty general .*nsCOMPtr<.*>.* etc
iirc ^nsCOMPtr<.*>$ doesn't work for some reason that I don't think I investigated, I wonder if its because $ needs a '\n' to match.  Does ^nsCOMPtr<.*>.* work? similar for the other regexps of course.

btw seems like we should probably add a pretty printer for mozilla::AlignedStorage

Comment 4

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Comment on attachment 8767072 [details]
Bug 1283763 - Fix gdb pretty printers for nsTArray.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61776/diff/1-2/

Comment 5

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

^nsCOMPtr<.*>.* works. Acctually, ^nsCOMPtr<.*>$ works for me as well. What type didn't work for you?

I think .*TArray is too general, it will match any template class which contains nsTArray.
I guess the best way is to explicitly list all types.

This patch also solved "mozilla::AlignedStorage2<nsTArray<mozilla::ipc::FileDescriptor> >".

Comment 6

[Trevor Saunders (:tbsaunde)]

(In reply to Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] from comment #5)
> ^nsCOMPtr<.*>.* works. Acctually, ^nsCOMPtr<.*>$ works for me as well. What
> type didn't work for you?

hrm, it works for me too now so I have no idea :(

> I think .*TArray is too general, it will match any template class which
> contains nsTArray.
> I guess the best way is to explicitly list all types.

yeah, or maybe \w+ or something would work, but just listing them all certainly does.

> This patch also solved
> "mozilla::AlignedStorage2<nsTArray<mozilla::ipc::FileDescriptor> >".

yeah as expected though of course we should add a printer for AlignedStorage right?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d73ad04a536
Fix gdb pretty printers for nsTArray. r=tbsaunde

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d73ad04a536