Closed
Bug 1283764
Opened 9 years ago
Closed 9 years ago
Inspector computed view : "No CSS properties found" message is no longer displayed
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox50 verified)
VERIFIED
FIXED
Firefox 50
Tracking | Status | |
---|---|---|
firefox50 | --- | verified |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
Attachments
(1 file)
STRs:
- open the inspector
- select a node with valid css properties (e.g. not a comment)
- go to the Computed tab
- enter some value in the filter which will not match anything
ER:
The message "No CSS properties found." should be displayed
AR:
The panel is empty.
This is a regression from Bug 1238133. The ruleview creates an element with the id "noResults" (dynamically, in devtools/client/inspector/rules/rules.js), and the computed view uses another element with the same id, declared in inspector.xul.
Now that the two views live in the same document, document.getElementById("noResults") always returns the element from the ruleview.
We should either use different ids or rely on a classname.
Assignee | ||
Updated•9 years ago
|
Component: Developer Tools: CSS Rules Inspector → Developer Tools: Inspector
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61792/
Attachment #8767118 -
Flags: review?(gl)
Assignee | ||
Comment 2•9 years ago
|
||
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8767118 [details]
Bug 1283764 - fix display of noResults message in inspector computedview;
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61792/diff/1-2/
Updated•9 years ago
|
Attachment #8767118 -
Flags: review?(gl) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8767118 [details]
Bug 1283764 - fix display of noResults message in inspector computedview;
https://reviewboard.mozilla.org/r/61792/#review58584
Assignee | ||
Comment 5•9 years ago
|
||
Thanks for the review!
Sent to try again after fixing two tests that had a reference to the old ids: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaa0703b75f24820beb562dc6dc74bdde4645d62
Try is green, checkin-needed.
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/05cb30a038a2
fix display of noResults message in inspector computedview;r=gl
Comment 7•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 8•9 years ago
|
||
I have reproduced this bug with Nightly 50.0a1(2016-07-01) with instruction from comment 0 and Linux x86.
The Bug's fix is now verified on Latest Developer Edition 50.0a2(2016-08-17)
Build ID:20160817004002
User Agent:Mozilla/5.0 (X11; Linux i686; rv:50.0) Gecko/20100101 Firefox/50.0
[bugday-20160817]
Comment 9•8 years ago
|
||
I have reproduced this bug with Nightly 50.0a1 (2016-07-01) on Windows 7, 64 Bit!
This bug's fix is verified with latest Developer Edition (Aurora)
Build ID 20160803004014
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
[testday-20160826]
![]() |
||
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•