1283768 - add a gdb helper to dereference smart pointers

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

I know this is trivial, but I really use this very often.

Comment 1

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Attachment: Bug 1283768 - Add a gdb helper to dereference smart pointers.

Review commit: https://reviewboard.mozilla.org/r/61784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61784/

Comment 2

[Trevor Saunders (:tbsaunde)]

(In reply to Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] from comment #0)
> I know this is trivial, but I really use this very often.

in unoptimized builds I think *somePtr and somePtr->mFoo should just work (at least they do for me so if they don't for you I'm curious why).  That said we should probably consider using https://sourceware.org/gdb/current/onlinedocs/gdb/Xmethods-In-Python.html#Xmethods-In-Python so people don't need to remember different commands.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8767080 [details]
Bug 1283768 - Add a gdb helper to dereference smart pointers.

I agree with Trevor, we shouldn't add new commands. (And in fact, we should probably remove the existing commands in .gdbinit now that we have pretty printers).

Comment 4

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> in unoptimized builds I think *somePtr and somePtr->mFoo should just work
> (at least they do for me so if they don't for you I'm curious why).  That
> said we should probably consider using
> https://sourceware.org/gdb/current/onlinedocs/gdb/Xmethods-In-Python.
> html#Xmethods-In-Python so people don't need to remember different commands.

I experienced some builds that can not follow operator-> properly, but I can't reproduce now.

(In reply to Mike Hommey [:glandium] from comment #3)
> Comment on attachment 8767080 [details]
> Bug 1283768 - Add a gdb helper to dereference smart pointers.
> 
> I agree with Trevor, we shouldn't add new commands. (And in fact, we should
> probably remove the existing commands in .gdbinit now that we have pretty
> printers).

Good idea.

Comment 5

[Trevor Saunders (:tbsaunde)]

(In reply to Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] from comment #4)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > in unoptimized builds I think *somePtr and somePtr->mFoo should just work
> > (at least they do for me so if they don't for you I'm curious why).  That
> > said we should probably consider using
> > https://sourceware.org/gdb/current/onlinedocs/gdb/Xmethods-In-Python.
> > html#Xmethods-In-Python so people don't need to remember different commands.
> 
> I experienced some builds that can not follow operator-> properly, but I
> can't reproduce now.

I expect it will happen in a optimized build because operator -> gets inlined, but the Xmethod thing should fix that.