1283798 - Autoland does not respect webidl mozhook

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Carsten Book [:Tomcat]]

In http://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/prevent_webidl_changes.py we have the hook to prevent webidl changes without dom peer review.

I was working on merging autoland to mozilla-central when i got the warning that the push failed because of webidl change without peer review.

Or to be concret "WebIDL file %s altered in changeset %s without DOM peer review\n" :)

So it seems that the mozreview autolander does not respect or override this hook ?

Comment 1

[Carsten Book [:Tomcat]]

gps: can you take a look, i guess we need to get this fixed, since overriding the hooks is i guess not such a good idea.

Btw the bug in question that caused the warning is https://bugzilla.mozilla.org/show_bug.cgi?id=1280545

Comment 2

[Gregory Szorc [:gps]]

I'll look into this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/86d0ea4d39d1
ansible/hg-ssh: add scm_autoland as a trusted group

Comment 4

[Gregory Szorc [:gps]]

The hook was installed but I'm pretty sure the issue was the hgrc file wasn't getting loaded due to a file ownership/trust issue. I'm deploying a fix now.

Comment 5

[Carsten Book [:Tomcat]]

problem is now that this still block the merge to m-c because of the bug that cause the hg hook warning (sent a separate mail)

Comment 6

[Gregory Szorc [:gps]]

I merged 2ba942ea44b0 from autoland into central and pushed with the WebIDL hook disabled on the server. I just saw Carsten's email saying I should merge aeb0f07f395ef8d829697d1062f2832b747ca5a8 (which is 3 changesets after 2ba942ea44b0). Someone can do that merge if they are so inclined. 

I ran Bugherder, so hopefully all bugs are resolved.

I did not merge autoland into other repos or merge central into autoland. I'll leave it up to the pros to do that.

Comment 7

[Gregory Szorc [:gps]]

Ugh. A typo in the .hgrc was causing hooks to not load. (The "[hooks]" section header was missing.)

The issue is now fixed.

Some changed did sneak in without DOM peer review:

remote: ************************** ERROR ****************************
remote:
remote: WebIDL file dom/webidl/BrowserElementAudioChannel.webidl altered in changeset 04420d139399 without DOM peer review
remote: WebIDL file dom/webidl/KillSwitch.webidl altered in changeset f00d45823516 without DOM peer review
remote: WebIDL file dom/webidl/Navigator.webidl altered in changeset 1a5c34f5aa20 without DOM peer review
remote: WebIDL file dom/webidl/ActivityRequestHandler.webidl altered in changeset 069a431e7053 without DOM peer review
remote: WebIDL file dom/webidl/MozActivity.webidl altered in changeset 069a431e7053 without DOM peer review
remote:
remote:
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..

Off to a DOM peer to audit the changes.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Those all look fine. retroactive-r=me.