1283800 - Storage inspector throws unhandled exception trying to access localStorage on about:home

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Jarda Snajdr [:jsnajdr]]

Step to reproduce:
1. Go to about:home (or any other about: page)
2. Open Storage Inspector
3. Expand the localStorage node

Expected result:
about:home is shown as a tree node under localStorage, reports that there is no data

Actual result:
Accessing window.localStorage throws a DOM exception that is not handled.

Comment 1

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d80fccaefce7

Comment 2

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09b2195c8727

Comment 3

[Jarda Snajdr [:jsnajdr]]

Attachment: Storage inspector throws unhandled exception trying to access localStorage on about:home

1. Fix the localStorage actor to handle the "storage" object being null
2. Issue a console warning when access to window's localStorage or cache fails
3. Fix the finishTests() in head.js - catch exception when window.localStorage access fails
4. Add a new mochitest

Everything applies also to sessionStorage, of course.

Note that his bug depends on 1283401, which fixes platform issues when access to cache fails in debug build

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8767163 [details] [diff] [review]
Storage inspector throws unhandled exception trying to access localStorage on about:home

Review of attachment 8767163 [details] [diff] [review]:
-----------------------------------------------------------------

We also need to bare in mind that storage is available to about pages but because they are chrome and not content the methods we would use to get them are likewise very different from obtaining storage from content.

Happy with this workaround for now though, r+.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c048aba03021
Storage inspector throws unhandled exception trying to access localStorage on about:home r=mratcliffe

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c048aba03021