1283880 - compare view with try push yields no data, appears to be loading from framework=7

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

take a look at this:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=fx-team&originalRevision=73817edbdfd6&newProject=try&newRevision=834c37f09c38fdd99898ea3c024111bf4619f7cb&framework=1&filter=damp&showOnlyImportant=0

there is valid data, and i have verified in the logs that we have perfherder_data and it is for the talos framework.  when we click subtests for linux64 damp, the base revision has data, but the new revision has none.

using devtools network requests, I see that we are loading data for the new revision with &framework=7, in fact this should be framework=1

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:wlach, can you take a look at this?

Comment 2

[William Lachance (:wlach)]

Yet another oversight in the implementation of the compare controllers, trivially fixable fortunately.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1283880 > mozilla:master

Comment 4

[William Lachance (:wlach)]

I'm just going to go ahead and merge this. :jmaher is away and it's trivial.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b1314086cc0052feaa168b04a64be71f3f3c4b32
Bug 1283880 - Fix display of compare subtest performance when branches differ (#1643)