1283901 - Intermittent devtools/client/webconsole/test/browser_console_error_source_click.js | view source opened -

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: [e-mail]

https://treeherder.mozilla.org/logviewer.html#?job_id=31081680&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux64/1467392182/mozilla-inbound_ubuntu64_vm_test-mochitest-devtools-chrome-8-bm113-tests1-linux64-build0.txt.gz

Comment 1

[Jarda Snajdr [:jsnajdr]]

The screenshot shows that the console message we want to click on has scrolled out of view, because there are multiple errors logged after it. We'll need to add a call to el.scrollIntoView().

Comment 2

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 1
* fx-team: 1
* autoland: 1
* ash: 1

Platform breakdown:
* linux64: 4
* osx-10-10: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1283901&startday=2016-07-04&endday=2016-07-10&tree=all

Comment 3

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* fx-team: 2
* autoland: 2

Platform breakdown:
* osx-10-10: 4
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1283901&startday=2016-07-11&endday=2016-07-17&tree=all

Comment 4

[Jarda Snajdr [:jsnajdr]]

Attachment: Intermittent devtools/client/webconsole/test/browser_console_error_source_click.js

Two changes that should resolve this:
- use node.click() instead of syntesizeEvent - it doesn't require the node to be visible (scrollIntoView), which I believe is the cause of this intermittent
- just to be sure, make the check for viewSourceCalled async. I'm a bit uneasy about how the test relies on the click event to be fired synchronously

Comment 5

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44787f7d261c

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8775997 [details] [diff] [review]
Intermittent devtools/client/webconsole/test/browser_console_error_source_click.js

Review of attachment 8775997 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_console_error_source_click.js
@@ +54,2 @@
>    for (let result of results) {
> +    let viewSourceCalled = defer();

Click fires synchronously so I don't think we need to convert this into promises.

Secondly, there's another project underway I believe to convert defer() to new Promise().  It would require increasing the nesting (unfortunate in this case but that's the plan AFAIK)

for (let result of results) {
  let viewSource = hud.viewSource;
  yield new Promise(resolve => {
    hud.viewSource = resolve;
    // rest of code
  });
  hud.viewSource = viewSource;
}

Regardless, I really don't think we need to make this async to fix the intermittent - nothing happening in the implementation is async.

Comment 7

[Jarda Snajdr [:jsnajdr]]

Attachment: Intermittent devtools/client/webconsole/test/browser_console_error_source_click.js

OK, then the only change is calling node.click() instead of synthesizeMouse.

Comment 8

[Jarda Snajdr [:jsnajdr]]

Try is good, requesting checkin.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/ebdc7c4a449f
Intermittent devtools/client/webconsole/test/browser_console_error_source_click.js. r=bgrins

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ebdc7c4a449f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dbda9917f836