Closed Bug 1283902 Opened 4 years ago Closed 3 years ago
_webapi _install .js | Uncaught exception - Error: expected on Download Ended but got on Download Progress
Filed by: email@example.com https://treeherder.mozilla.org/logviewer.html#?job_id=31078275&repo=mozilla-inbound http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1467383500/mozilla-inbound_win7_ix_test_pgo-mochitest-e10s-browser-chrome-6-bm110-tests1-windows-build93.txt.gz
This sounds like a case of the test just having to account for the possibility of more than one onDownloadProgress events before onDownloadEnded, but I can't seem to run the test locally: I get a "ReferenceError: SECURE_TESTROOT not found" message when I try this command: >./mach mochitest -f browser toolkit/mozapps/extensions/test/browser/browser_webapi_install.js Is there a special way one is meant to run these tests?
I agree with your assessment of the cause of the failure. The problem you encountered is due to bug 1286016, the simplest workaround (assuming you're not on Windows) is to run one of the tests from browser.ini (e.g., browser_about.js) once and then run the webapi install test.
Thanks for that tip, Andrew! Here's a patch that skips repeated progress events, so the test won't fail intermittently in that case.
Assignee: nobody → wisniewskit
Status: NEW → ASSIGNED
Attachment #8772191 - Flags: review?(gavin.sharp)
Attachment #8772191 - Flags: review?(gavin.sharp) → review?(aswan)
Comment on attachment 8772191 [details] [diff] [review] 1283902-skip_repeated_onDownloadProgress_events_in_test.diff This looks good, thanks! (And sorry I missed your first review request) But now that check() can run safely if receivedEvents is empty, can you update the code right below to just call check() immediately instead of deferring it if there are no queued events?
No problem, here's a version of the patch with that change. Carrying over r+, and requesting checkin.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/4b3698309e6c Skip repeated onDownloadProgress events so the test may pass. r=aswan
nice, thanks Thomas!
You need to log in before you can comment on or make changes to this bug.