Add a virtual folder to Pootle that contains the toolkit strings for Thunderbird

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: akmalxster, Assigned: leandro.regueiro)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
Hello.Can you add Uzbek theese services, please?
Yes, I will be looking into this. Thank you for filing the bug!
Flags: needinfo?(philipp)
Created attachment 8770672 [details]
Output from compare-locales

Hi Akmal,

thank you for your translations, I am looking forward to including them in Thunderbird. Unfortunately there are still a few missing strings and also a few parsing errors I am concerned about.

The missing strings are mostly not in the Thunderbird project, but in toolkit. This is the common core of the Mozilla Platform, which is shared among Firefox and Thunderbird.

You can find the strings for translation at https://mozilla.locamotion.org/uz/firefox/toolkit/ and https://mozilla.locamotion.org/uz/firefox/dom/

We normally ask translations to at least be 90% complete (going by the percentage in compare-locales, see the attachment). Can you at least fix the netErrorApp.dtd issue?

I also see that there are some Thunderbird strings compare-locales has not picked up, but that you have translated everything on 
mozilla.locamotion.org. I'm CC'ing flod to see if he can help me understand that or refer me to the right person.
Flags: needinfo?(philipp)
Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(akmalxster)
Thunderbid only has specific Thunderbird strings, shared strings (like toolkit or dom) are available inside Firefox on Pootle.

In case, Dwayne Bailey or Leandro Regueiro from the Pootle's team are available on Bugzilla.
Flags: needinfo?(francesco.lodolo)
I understand that shared strings are in Firefox, I was more interested in why https://mozilla.locamotion.org/uz/thunderbird/ shows 0 strings needing translation, but compare-locales with current l10n/mozilla-aurora shows various differences in mail/ (see attachment). Leandro, can you shed some light on this?
Flags: needinfo?(leandro.regueiro)
(In reply to Philipp Kewisch [:Fallen] from comment #4)
> I understand that shared strings are in Firefox, I was more interested in
> why https://mozilla.locamotion.org/uz/thunderbird/ shows 0 strings needing
> translation, but compare-locales with current l10n/mozilla-aurora shows
> various differences in mail/ (see attachment). Leandro, can you shed some
> light on this?

Sorry, completely missed there were strings reported missing in /mail.

It's expected for Pootle to not touch productization files like region.properies or /searchplugins, I wonder if the others are strings landed in the last cycle.
Created attachment 8770686 [details]
Output from compare-locales

Sorry, here is an updated compare-locales for Thunderbird, comm-aurora wasn't updated. There are still missing strings in compare-locales for mail/ though, even though locamotion says no missing strings.
Attachment #8770672 - Attachment is obsolete: true
Looking at e.g. keepDrafts2, this was added in bug 951748 which landed on comm-central 2 months ago and is now on aurora. Maybe Thunderbird was just not updated on Pootle or something?

Comment 8

2 years ago
Hi All, strings were indeed missing from Pootle but present in comm-aurora checkout. We had the same Mercurial double head on comm-aurora that we solved on mozilla-aurora.  I've fixed this now by recloning comm-aurora.  Thunderbird will update shortly.

My bad I didn't think to check this on comm-aurora at the same time as we saw the mozilla-aurora issue.
Flags: needinfo?(leandro.regueiro)
(Assignee)

Comment 9

2 years ago
(In reply to Philipp Kewisch [:Fallen] from comment #2)
>
> The missing strings are mostly not in the Thunderbird project, but in
> toolkit. This is the common core of the Mozilla Platform, which is shared
> among Firefox and Thunderbird.
> 
> You can find the strings for translation at
> https://mozilla.locamotion.org/uz/firefox/toolkit/ and
> https://mozilla.locamotion.org/uz/firefox/dom/

Hi,
Does Thunderbird share all files in toolkit and dom directories? If it can be restricted to some specific files we can create a specific virtual folder, like "shared" which contains shared strings for Firefox for Android in Firefox.

If only some of the files in those two directories are actually shared, can you please provide specific lists for both Thunderbird and Lightning for us to create new virtual folders?


Thanks in advance.
(In reply to Leandro Regueiro from comment #9)
> Hi,
> Does Thunderbird share all files in toolkit and dom directories? If it can
> be restricted to some specific files we can create a specific virtual
> folder, like "shared" which contains shared strings for Firefox for Android
> in Firefox.
> 
> If only some of the files in those two directories are actually shared, can
> you please provide specific lists for both Thunderbird and Lightning for us
> to create new virtual folders?

Ooh nice, I didn't know it was possible to create virtual folders. Our l10n.ini is here:
https://dxr.mozilla.org/comm-central/source/mail/locales/l10n.ini

It has the same toolkit include that Firefox has, so it should have the same virtual folders listed here:
https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/l10n.ini

Lightning does not have any additional includes.
(Assignee)

Comment 11

2 years ago
(In reply to Philipp Kewisch [:Fallen] from comment #10)
> (In reply to Leandro Regueiro from comment #9)
> > Hi,
> > Does Thunderbird share all files in toolkit and dom directories? If it can
> > be restricted to some specific files we can create a specific virtual
> > folder, like "shared" which contains shared strings for Firefox for Android
> > in Firefox.
> > 
> > If only some of the files in those two directories are actually shared, can
> > you please provide specific lists for both Thunderbird and Lightning for us
> > to create new virtual folders?
> 
> Ooh nice, I didn't know it was possible to create virtual folders. Our
> l10n.ini is here:
> https://dxr.mozilla.org/comm-central/source/mail/locales/l10n.ini
> 
> It has the same toolkit include that Firefox has, so it should have the same
> virtual folders listed here:
> https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/l10n.ini
> 
> Lightning does not have any additional includes.

Hi,
but are those whole directories actually necessary for Thunderbird? If we can narrow the list to some specific files instead of whole directories that would be better since translators can focus on a smaller set of strings.


Thanks in advance
We currently have no way to see which strings are being used, especially since some of the strings are being used indirectly, e.g. by dialogs provided by toolkit/. Does Firefox have some way to narrow down the strings being used or does it require a full translation of the toolkit directories?

Comment 13

2 years ago
Hi Philipp for Firefox we assume the whole toolkit is required.  For Firefox for Android we manually created a shared subset.  This is based on looking to see which things where actually needed.  We simply provide a list of files, not a list of units.  So I guess the question is whether we could make such a subset of those for Thunderbird.  But seems from your comments that that isn't possible.
You are right, sorry. We have no way to select specific strings, please include the whole toolkit.
(Assignee)

Comment 15

2 years ago
It took a bit more time than expected but we have added a new "tbshared" virtual folder that comprises the shared translations between Firefox and Thunderbird. This way it is much easier to check if a language has a complete translation for Thunderbird. The new virtual folder can be seen for each of the languages in https://mozilla.locamotion.org/projects/firefox/
(Assignee)

Comment 16

2 years ago
In particular Uzbek still has to complete these translations https://mozilla.locamotion.org/uz/firefox/translate/tbshared/#filter=incomplete
(Assignee)

Comment 17

2 years ago
In an unrelated note, the old "shared" virtual folder has been renamed to "androidshared" since it only comprises the shared translations between Firefox and Firefox for Android.
Great, thank you very much! This will be very helpful for future Thunderbird localizations, I'll do a quick post on m.d.l10n about this so everyone knows. As we've drifted off from the original intent of this bug I suggest we close this bug.

Akmal, I'd appreciate if you could complete the now missing translations and file a new bug once you are done!
Assignee: nobody → leandro.regueiro
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(akmalxster)
Resolution: --- → FIXED
Summary: Add uz (Uzbek) to mail/locales/all-locales and calendar/locales/all-locales → Add a virtual folder to Pootle that contains the toolkit strings for Thunderbird
Leandro, I was just checking this for another locale and it looks like the virtual folder is missing. I checked https://mozilla.locamotion.org/kab/thunderbird/ (and also https://mozilla.locamotion.org/uz/thunderbird/), but I don't see toolkit there. Any idea what is going on?
Flags: needinfo?(leandro.regueiro)
(Assignee)

Comment 20

2 years ago
The virtual folders are always on the Firefox project for the language. See https://mozilla.locamotion.org/kab/firefox/ and https://mozilla.locamotion.org/uz/firefox/

In other words, none of the Thunderbird projects has any virtual folder at all. This is because to avoid translators translating twice the shared translations were kept in a single place (the Firefox project) and the "tbshared" and "androidshared" are used to highlight the shared translations in Firefox project with Thunderbird and Firefox for Android projects.
Thanks for the clarification. I can see this causing some confusion though since localizers may think that if Thunderbird is at 100% then they are done. If it is just a virtual folder pointing to the real strings, would they really be translating twice? Wouldn't doing it once translate it in the actual folder it is in?
(Assignee)

Comment 22

2 years ago
Yes, it may happen that translators think that translation is 100%. We are currently relying on translators completing first Firefox, and that they at least read translation instructions in the side panel for Thunderbird.

Virtual folders point to the real strings the same way real directories do. If two different translators are translating the strings in a directory there is a chance of clash. The same happens if one of them is translating a virtual folder while the other is translating a regular directory. Not sure if this solves your doubt.
(Assignee)

Updated

2 years ago
Flags: needinfo?(leandro.regueiro)
You need to log in before you can comment on or make changes to this bug.