1283999 - Unable to locate element by link text in XHTML documents

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

See https://github.com/mozilla/geckodriver/issues/137

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1283999 - Rewrite and complement element retrieval tests;

Many tests for the plural Find Element, Find Element From Element,
and FInd Elements From Element commands were missing.

Review commit: https://reviewboard.mozilla.org/r/61910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61910/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1283999 - Rename element retrieval tests to match spec;

The test_findelement.py name is misleading because it covers tests for
commands Find Element, Find Elements, Find Element From Element, Find
Elements From Element, and Get Active Element.

Review commit: https://reviewboard.mozilla.org/r/61912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61912/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1283999 - Run element retrieval tests on XHTML documents;

Review commit: https://reviewboard.mozilla.org/r/61914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61914/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1283999 - Fix lookup of hyperlinks in XHTML documents;

Lower-case "a" matches hyperlinks in XHTML documents as well as HTML
documents. Upper-case "A" only matches HTML documents.

The patch also refactors link text- and partial link text lookup into
distinct functions, so that there is no more worry about variable scoping
in match blocks.

Review commit: https://reviewboard.mozilla.org/r/61916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61916/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1283999 - Publish XPath find element functions;

Publish the findByXPath and findAllByXPath functions to match the style
of the recently introduces findByLinkText and findByPartialLinkText
functions.

Do note that this patch rearranges the input arguments these functions
take.  Possibly we do not have to send the root element as input at all.

Review commit: https://reviewboard.mozilla.org/r/61918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61918/

Comment 6

[David Burns :automatedtester]

Comment on attachment 8767421 [details]
Bug 1283999 - Rewrite and complement element retrieval tests;

https://reviewboard.mozilla.org/r/61910/#review58830

Comment 7

[David Burns :automatedtester]

Comment on attachment 8767422 [details]
Bug 1283999 - Rename element retrieval tests to match spec;

https://reviewboard.mozilla.org/r/61912/#review58832

Comment 8

[David Burns :automatedtester]

Comment on attachment 8767423 [details]
Bug 1283999 - Run element retrieval tests on XHTML documents;

https://reviewboard.mozilla.org/r/61914/#review58834

Comment 9

[David Burns :automatedtester]

Comment on attachment 8767424 [details]
Bug 1283999 - Fix lookup of hyperlinks in XHTML documents;

https://reviewboard.mozilla.org/r/61916/#review58836

Comment 10

[David Burns :automatedtester]

Comment on attachment 8767425 [details]
Bug 1283999 - Publish XPath find element functions;

https://reviewboard.mozilla.org/r/61918/#review58838

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5118b19b4aa7
Rewrite and complement element retrieval tests; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/61aa05b0a291
Rename element retrieval tests to match spec; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/88db59b4e611
Run element retrieval tests on XHTML documents; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/50de407be97c
Fix lookup of hyperlinks in XHTML documents; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/a55102c5ea8c
Publish XPath find element functions; r=automatedtester

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5118b19b4aa7
https://hg.mozilla.org/mozilla-central/rev/61aa05b0a291
https://hg.mozilla.org/mozilla-central/rev/88db59b4e611
https://hg.mozilla.org/mozilla-central/rev/50de407be97c
https://hg.mozilla.org/mozilla-central/rev/a55102c5ea8c

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/74e83213e48a
https://hg.mozilla.org/releases/mozilla-aurora/rev/1c7797992d06
https://hg.mozilla.org/releases/mozilla-aurora/rev/86b1691ed273
https://hg.mozilla.org/releases/mozilla-aurora/rev/42fc9e165219
https://hg.mozilla.org/releases/mozilla-aurora/rev/fa4681fe062f