Closed Bug 1283999 Opened 3 years ago Closed 3 years ago

Unable to locate element by link text in XHTML documents

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(5 files)

Many tests for the plural Find Element, Find Element From Element,
and FInd Elements From Element commands were missing.

Review commit: https://reviewboard.mozilla.org/r/61910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61910/
Attachment #8767421 - Flags: review?(dburns)
Attachment #8767422 - Flags: review?(dburns)
Attachment #8767423 - Flags: review?(dburns)
Attachment #8767424 - Flags: review?(dburns)
Attachment #8767425 - Flags: review?(dburns)
The test_findelement.py name is misleading because it covers tests for
commands Find Element, Find Elements, Find Element From Element, Find
Elements From Element, and Get Active Element.

Review commit: https://reviewboard.mozilla.org/r/61912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61912/
Lower-case "a" matches hyperlinks in XHTML documents as well as HTML
documents. Upper-case "A" only matches HTML documents.

The patch also refactors link text- and partial link text lookup into
distinct functions, so that there is no more worry about variable scoping
in match blocks.

Review commit: https://reviewboard.mozilla.org/r/61916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61916/
Publish the findByXPath and findAllByXPath functions to match the style
of the recently introduces findByLinkText and findByPartialLinkText
functions.

Do note that this patch rearranges the input arguments these functions
take.  Possibly we do not have to send the root element as input at all.

Review commit: https://reviewboard.mozilla.org/r/61918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61918/
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8767421 [details]
Bug 1283999 - Rewrite and complement element retrieval tests;

https://reviewboard.mozilla.org/r/61910/#review58830
Attachment #8767421 - Flags: review?(dburns) → review+
Comment on attachment 8767422 [details]
Bug 1283999 - Rename element retrieval tests to match spec;

https://reviewboard.mozilla.org/r/61912/#review58832
Attachment #8767422 - Flags: review?(dburns) → review+
Attachment #8767423 - Flags: review?(dburns) → review+
Attachment #8767424 - Flags: review?(dburns) → review+
Comment on attachment 8767425 [details]
Bug 1283999 - Publish XPath find element functions;

https://reviewboard.mozilla.org/r/61918/#review58838
Attachment #8767425 - Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5118b19b4aa7
Rewrite and complement element retrieval tests; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/61aa05b0a291
Rename element retrieval tests to match spec; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/88db59b4e611
Run element retrieval tests on XHTML documents; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/50de407be97c
Fix lookup of hyperlinks in XHTML documents; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/a55102c5ea8c
Publish XPath find element functions; r=automatedtester
You need to log in before you can comment on or make changes to this bug.