1284027 - Images that Contain Errors Missing a Save Context Menu Option

Status: NEW

(Firefox :: Menus, defect, P3)

Description

[u564464]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160610120335

Steps to reproduce:

Requested the URL of an invalid (non icon/image format) favicon.ico file, causing Firefox to display the error message "The image "http://host/favicon.ico" cannot be displayed because it contains errors".


Actual results:

The right-click context menu on the resulting file contains errors page has a "Copy Image" option. This option has no effect and did not copy anything because the invalid favicon file is not actually an image format.
There is also no "Save Page As" context menu option, even in view-source.


Expected results:

There shouldn't be a "copy image" context menu option if the favicon.ico file "contains errors". Instead , there should be a "Save Page As" menu option so that the raw file, whatever it may be, can be downloaded by the user.
I know for a fact that older versions of Firefox used to have the "Save Page As" option even if the favicon was invalid.

Ability to save an invalid favicon.ico file is useful for web developers trying to debug an invalid favicon on a website.

Comment 1

[Tooru Fujisawa [:arai]]

Can you provide the actual URL of the favicon.ico ?

Comment 2

[u564464]

http://thejadednetwork.com/favicon.ico
This example has an empty 0 byte favicon file.
I've also tested it with an invalid favicon that has data (e.g. 'test'), and the "Copy Image" option doesn't copy anything even if there is data in the file.

Comment 3

[Tooru Fujisawa [:arai]]

https://dxr.mozilla.org/mozilla-central/rev/39dffbba764210b25bfc1e749b4f16db77fa0d46/browser/base/content/nsContextMenu.js#470
>     // Copy image contents depends on whether we're on an image.
>     this.showItem("context-copyimage-contents", this.onImage);

The menu item is shown if it's on image, regardless of correctly loaded or not.

Comment 4

[u564464]

(In reply to Tooru Fujisawa [:arai] (almost away until April) from comment #3)
> https://dxr.mozilla.org/mozilla-central/rev/
> 39dffbba764210b25bfc1e749b4f16db77fa0d46/browser/base/content/nsContextMenu.
> js#470
> >     // Copy image contents depends on whether we're on an image.
> >     this.showItem("context-copyimage-contents", this.onImage);
> 
> The menu item is shown if it's on image, regardless of correctly loaded or
> not.

Ok, so I guess the issue is not that there is a Copy Image option, but that the "Save Image As" option is missing if the image is determined to be containing errors, making it impossible to download the file directly from the browser window.

Also, this is not limited to just favicons; any images that contain errors lack a save menu option.

Comment 5

[u564464]

(In reply to spammonster2011 from comment #4)
> Ok, so I guess the issue is not that there is a Copy Image option, but that
> the "Save Image As" option is missing if the image is determined to be
> containing errors, making it impossible to download the file directly from
> the browser window.

Correction: the workaround to save the file is by using Ctrl-S