Closed
Bug 1284080
Opened 8 years ago
Closed 8 years ago
Improve the Thunderbird start menu tile on Windows 8/10
Categories
(Thunderbird :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 50.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(3 files, 2 obsolete files)
The Thunderbird logo is small in Start menu tile of Windows 8/10.
Assignee | ||
Comment 1•8 years ago
|
||
This is a port from bug 1232679. I tested it on Win8 and 10. The only thing I'm not so happy is the text over the icons. I could also disable the text and show only the icon like in small icon mode. Jörg, now you have a Win10 machine and can test it by right clicking the thunderbird.exe and choose Add to Start.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8767506 -
Flags: review?(mozilla)
Assignee | ||
Comment 2•8 years ago
|
||
At the left is the icon without this patch and the others the different channels with patch.
Assignee | ||
Updated•8 years ago
|
Attachment #8767507 -
Attachment description: screenshot of the icons → screenshot of the tiles
Comment 3•8 years ago
|
||
Why not make the image 10% smaller so the text fits below it?
Assignee | ||
Comment 4•8 years ago
|
||
I thought about reducing the size but hadn't followed it. Same patch with now reduced icons.
Attachment #8767506 -
Attachment is obsolete: true
Attachment #8767506 -
Flags: review?(mozilla)
Attachment #8767512 -
Flags: review?(mozilla)
Comment 5•8 years ago
|
||
Can I be very pedantic? The egg is too big, it touches the text. May I suggest to make it roughly as big as in my attachment (sorry, all fuzzy due to up-scaling). <off topic> I haven't used the original Windows start menu since Win 7. I'm always using Classic Shell to avoid all the brilliant (not) new ideas M$ is coming up with to dictate how I should use *my* computer. </off topic>
Assignee | ||
Comment 6•8 years ago
|
||
I think this works. The text doesn't touch the icons and has some gap.
Attachment #8767512 -
Attachment is obsolete: true
Attachment #8767512 -
Flags: review?(mozilla)
Attachment #8767516 -
Flags: review?(mozilla)
Comment 7•8 years ago
|
||
Comment on attachment 8767516 [details] [diff] [review] startMenuIcon.patch Review of attachment 8767516 [details] [diff] [review]: ----------------------------------------------------------------- I'm not really qualified to review this. I don't know what all the various files do (.xml, .build, .in) and I've only seen the 150px PNG for Daily in action. I have however looked at the other images in GIMP (and I even checked that the bird wing doesn't go down too much to touch the text). Given that this is a port of bug 1232679, I hope that the TB version is correct. However, I noticed a difference in file count between the TB and FF versions: FF has eight .xml files (including two "unofficial" ones), TB has six. TB has two moz.build and FF only has one .mozbuild. So despite all those doubts: r=jorgk.
Attachment #8767516 -
Flags: review?(mozilla) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/65f593683f26
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
You need to log in
before you can comment on or make changes to this bug.
Description
•