[TV][Home] Disable "decks can be moved into folder" feature

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jacklin, Assigned: lchang)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.6?)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Blocks: 1254038
blocking-b2g: --- → 2.6?
(Assignee)

Updated

3 years ago
Assignee: nobody → lchang
Status: NEW → ASSIGNED
Created attachment 8767924 [details] [review]
[gaia] luke-chang:1284174_tv_disable_moving_deck_into_folder > mozilla-b2g:v2.6
(Assignee)

Comment 2

3 years ago
Comment on attachment 8767924 [details] [review]
[gaia] luke-chang:1284174_tv_disable_moving_deck_into_folder > mozilla-b2g:v2.6

Hi Rex,

This bug is going to revert the feature of bug 1263523, which enables Decks in the folder. Besides, we need to make sure that the "add folder" button shouldn't appear when user first time boots the TV (since there are only decks on the screen).

I also added a timer in "checkAddFolderButton" function to avoid some unnatural animations (e.g. fade out and immediately fade in) when doing continuous actions.

Could you take a look at this? Thanks.
Attachment #8767924 - Flags: review?(rexboy)
Comment on attachment 8767924 [details] [review]
[gaia] luke-chang:1284174_tv_disable_moving_deck_into_folder > mozilla-b2g:v2.6

Please add comments to describe what setTimeout is trying to resolve before landing.
Attachment #8767924 - Flags: review?(rexboy) → review+
Summary: [TV][Home] Main decks can not be moved to folders → [TV][Home] Disable "decks can be moved into folder" feature
(Assignee)

Comment 4

3 years ago
Rex, Thanks. Comments have been added.

landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/f6a3318b61e1452b447f10043ebdce81b83e9b7d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.