1284206 - Update VIXL to 1.11

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Makoto Kato [:m_kato]]

When using ENABLE_ION=1 without JS_SIMULATOR_ARM64, we cannot compile VIXL Because MacroAssember-vixl references TraceParameters even if not JS_SIMULATOR_ARM64.

This is fixed by VIXL 1.11.  So we should update it to 1.11.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Update VIXL to 1.11

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8767598 [details] [diff] [review]
Update VIXL to 1.11

When using ENABLE_ION=1 without JS_SIMULATOR_ARM64, we cannot compile arm64 JIT due to VIXL issue.  
This is already fixed by VIXL 1.11.  So we should update it to 1.11.

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 8767598 [details] [diff] [review]
Update VIXL to 1.11

Review of attachment 8767598 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this.

::: js/src/jit/arm64/vixl/Simulator-vixl.h
@@ +768,4 @@
>    #undef DECLARE
>  
> +  #define DECLARE(A) \
> +      virtual void Visit##A(const Instruction* instr);

This definition of DECLARE is the same as the one above.

@@ +2569,5 @@
>      return (result >> (reg_size - 1)) & 1;
>    }
>  
>    static int CalcZFlag(uint64_t result) {
> +    return (result == 0) ? 1 : 0;

It seems they too have been bitten by "bools are not always 0 or 1 in opt builds" !

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Sean Stangl [:sstangl] from comment #3)
> Comment on attachment 8767598 [details] [diff] [review]
> Update VIXL to 1.11
> 
> Review of attachment 8767598 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for doing this.
> 
> ::: js/src/jit/arm64/vixl/Simulator-vixl.h
> @@ +768,4 @@
> >    #undef DECLARE
> >  
> > +  #define DECLARE(A) \
> > +      virtual void Visit##A(const Instruction* instr);
> 
> This definition of DECLARE is the same as the one above.

I will merge it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1450ae4e9e4f
Update VIXL to 1.11. r=sstangl

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1450ae4e9e4f