128422 - all users receive email on all changes regardless of email preferences

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The code in bug 117060, checked into the tip recently, has a serious bug that
causes all users to receive email on all changes regardless of their email
preferences, because it no longer stores email preferences that are "off" and
assumes missing preferences are "off", while processmail assumes missing
preferences are "on" so that adding a new preference defaults that preference to
"on" for all users.

A side-effect (or perhaps separate bug) is that when an installation adds a new
preference, processmail correctly defaults it to "on" for all users, but when a
user goes to the email preferences tab for the first time after the preference
has been added all the checkboxes for the preference are un-checked.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes bug by writing "off" preferences to the database

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Re-assigning to patch author.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Accepting.

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 72028 [details] [diff] [review]
patch v1: fixes bug by writing "off" preferences to the database

Er... yes. Oops. Serves me right for changing how things work during
templatisation.

Gerv

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checked this in without second review due to severity of the horkage (much worse
than failing most tests), but will wait for second review to resolve the bug fixed.

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.28; previous revision: 1.27
done

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 72028 [details] [diff] [review]
patch v1: fixes bug by writing "off" preferences to the database

r= justdave

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Resolving fixed.