1284245 - Iframes list is overlapping the Toolbox buttons

Status: NEW

(DevTools :: Framework, defect, P3)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Attachment: Screencast showing the issue

[Affected versions]:
- latest Nightly 50.0a1 (2016-07-03)
- latest Aurora 49.0a2 (2016-07-03)

[Affected platforms]:
- Windows 10 x64
- Ubuntu 14.04 x86
- Mac OS x 10.11

[Steps to reproduce]:
1. Launch Firefox with a new profile
2. Hit Ctrl+Shift+I (or Cmd+Opt+I) in order to open the Toolbox
3. Click the frame selection command button ("Select an iframe as the currently targeted document")
- inspect the iframes list

[Expected result]:
- The iframes list is displayed properly and all the Toolbox elements are visible

[Actual result]:
- The iframes list is overlapping the Toolbox buttons (see attached screencast)

[Regression range]:
- Last good revision: 3435dd7ad71fe9003bdeee18fd38d815e033beef
- First bad revision: dc4d7f68030e9edd22ad0bb0bd2244d047dd767d
- Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3435dd7ad71fe9003bdeee18fd38d815e033beef&tochange=dc4d7f68030e9edd22ad0bb0bd2244d047dd767d

Triggered by Bug 1266419 

[Additional notes]:
- Beta and RC builds are not affected

Comment 1

[Brian Grinstead [:bgrins]]

Depends on a solution from Bug 1274551.  The frames list is being opened at a hardcoded x/y position and when the menu shows up on top it covers up the toolbox.

Does this happen on any page with frames (even if it just has 1) or only if it has a lot of frames as in the screencast?

Comment 2

[Brian Grinstead [:bgrins]]

I think it's too early to prioritize this since it's awaiting triage

Comment 3

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Brian Grinstead [:bgrins] from comment #1)

> Does this happen on any page with frames (even if it just has 1) or only if
> it has a lot of frames as in the screencast?

Hello! Yes, indeed, this issue affects only the pages with lots of frames.

Comment 4

[arni2033]

Attachment: bug 1284245 enhancement (sic!) - half of screen is overlapped.png

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Attachment: nightly build 1.png

arni2033, do you still see that issue happened in latest nightly? I didn't saw any overlapping on my local nightly build (see my attachment)

Comment 6

[arni2033]

Comment on attachment 8775039 [details]
nightly build 1.png

>>>   My Info:   Win7_64, Nightly 50, 32bit, ID 20160726080520 (2016-07-26)
On my Windows 7 I see exactly the same (see attachment 8771600 [details]). Url for testing:

data:text/html,<script>S="<iframe></iframe>";for(i=0;i++<7;)S+=S;location="data:text/html,"+S</script>

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Yeah! I reproduced it on Mac by shrinking firefox window to fit half of my laptop screen and moving firefox to the left of my screen too. Iframes list will overlap on toolbox buttons once clicking button.

I suspected that root cause is around in toolbox.js at [1] which calculates menu X, Y position.


[1] https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/toolbox.js#1653-1656

Comment 8

[Ricky Chien [:rickychien] (inactive)]

I suspect that affected commit is https://hg.mozilla.org/mozilla-central/rev/62ce2708b5be.

It updated menu APIs part so would be the most suspicious one to cause this regression.

However, it is unable to be verified by reverting this patch since it caused other conflict. I'll look at this patch and see what we can do.

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Oh, I should be aware of comment 1 mentioned and it told this solution will depend on bug 1274551.

I think we should wait for bug 1274551 and hear the feedback for Honza since he probably have a better idea for how to deal with it. Unassigned myself from now.

Comment 10

[Johnny Stenback (:jst)]

Joe, please help triage this for 49.

Comment 11

[Brian Grinstead [:bgrins]]

I think this is fix-optional.  We could uplift if Bug 1274551 is fixed in time, but it's only triggering in pages with a lot of iframes

Comment 12

[Patrick Brosset <:pbro>]

No work on this since this was last triaged. Let's update the release tracking flags.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Seems highly unlikely that bug 1274551 will get fixed in time to consider backporting to 52, but leaving it on the radar just in case.

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

primary fix still hasn't landed in nightly