Closed Bug 1284283 Opened 4 years ago Closed 4 years ago

Remove MozContact API Android backend

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Firefox OS is gone.  But Firefox Android always initialize java code for MozContact Android backend.   We should remove it.
Blocks: fatfennec
Yeah, I remember looking at this in the past (when FxOS still existed and we nevertheless wanted to remove this from Fennec). This bugs could be helpful: bug 1193431, bug 1240598.
Blocks: 1240598, 1193431
Assignee: nobody → m_kato
Status: NEW → ASSIGNED
Comment on attachment 8778772 [details]
Bug 1284283 - Remove MozContact API Android backend.

https://reviewboard.mozilla.org/r/69942/#review67102

LGTM.

- Did you already push this to try?

- The original patch in bug 1193431 removed some strings too (strings.xml.in, browser.properties). Can we remove them in this patch too or are they still needed?
Attachment #8778772 - Flags: review?(s.kaspari) → review+
Do you still want to push this over the finish line?
Flags: needinfo?(m_kato)
(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> Comment on attachment 8778772 [details]
> Bug 1284283 - Remove MozContact API Android backend.
> 
> https://reviewboard.mozilla.org/r/69942/#review67102
> 
> LGTM.
> 
> - Did you already push this to try?

Yes.  Also, we still turn off mozContact API on Android's mochitest because it doesn't work on our test infra.

> - The original patch in bug 1193431 removed some strings too
> (strings.xml.in, browser.properties). Can we remove them in this patch too
> or are they still needed?

Oh, OK, I will merge this removable.
Flags: needinfo?(m_kato)
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/181336fdda66
Remove MozContact API Android backend. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/181336fdda66
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Duplicate of this bug: 1193431
You need to log in before you can comment on or make changes to this bug.