Closed Bug 1284349 Opened 4 years ago Closed 4 years ago

rm confusing assignment from NewObjectWithClassProtoCommon

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

protoArg is null so this assignment doesn't make sense:
  http://searchfox.org/mozilla-central/rev/a7c8e9f3cc323fd707659175a46826ad12899cd1/js/src/jsobj.cpp#788

Patch also does a tiny bit of tidying up while I'm here.
Attached patch simplify-new-objSplinter Review
Attachment #8767777 - Flags: review?(jorendorff)
Attachment #8767777 - Flags: review?(jorendorff) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/722d2bea3844
rm confusing assignment from NewObjectWithClassProtoCommon (r=jorendorff)
https://hg.mozilla.org/mozilla-central/rev/722d2bea3844
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.