git mozreview push shows message about requiring the review board client extension with cinnabar 0.4.0b1

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The message in question:
REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst

That can be argued as a problem in cinnabar not prefixing with "remote: ", but there also is a problem in git-mozreview: it's assuming "REVIEWBOARD:" is always preceded with "remote:", which may not well be the case if/when cinnabar is localized.
(Assignee)

Comment 1

2 years ago
Created attachment 8767806 [details]
Bug 1284366 - Hide server messages containing "REVIEWBOARD:", whether they are preceded with "remote:" or not.

Review commit: https://reviewboard.mozilla.org/r/62224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62224/
Attachment #8767806 - Flags: review?(gps)

Comment 2

2 years ago
Comment on attachment 8767806 [details]
Bug 1284366 - Hide server messages containing "REVIEWBOARD:", whether they are preceded with "remote:" or not.

https://reviewboard.mozilla.org/r/62224/#review59192
Attachment #8767806 - Flags: review?(gps) → review+

Comment 3

2 years ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/530a34bf549a
Hide server messages containing "REVIEWBOARD:", whether they are preceded with "remote:" or not. r=gps
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.