1284366 - git mozreview push shows message about requiring the review board client extension with cinnabar 0.4.0b1

Status: RESOLVED FIXED

(MozReview Graveyard :: Integration: Git, defect)

Description

[Mike Hommey [:glandium]]

The message in question:
REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst

That can be argued as a problem in cinnabar not prefixing with "remote: ", but there also is a problem in git-mozreview: it's assuming "REVIEWBOARD:" is always preceded with "remote:", which may not well be the case if/when cinnabar is localized.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1284366 - Hide server messages containing "REVIEWBOARD:", whether they are preceded with "remote:" or not.

Review commit: https://reviewboard.mozilla.org/r/62224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62224/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8767806 [details]
Bug 1284366 - Hide server messages containing "REVIEWBOARD:", whether they are preceded with "remote:" or not.

https://reviewboard.mozilla.org/r/62224/#review59192

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/530a34bf549a
Hide server messages containing "REVIEWBOARD:", whether they are preceded with "remote:" or not. r=gps