1284379 - Default File Name of Exported Address Book Should Reflect Name of the Address Book

Status: RESOLVED FIXED

(MailNews Core :: Address Book, enhancement)

Description

[David E. Ross]

Windows 7 Ultimate SP1
Thunderbird 45.2.0

I wanted to see if bug #1182460 was indeed fixed.  I have four address books.  When I attempted to export all address books at once, I got four Export Address Book navigation windows, each with a blank file name.  The file names should instead default to the names of the address books being exported.  

Yes, I know the address book names appear in the title bar of the navigation windows.  There is a risk, however, of mis-entering the name when manually typing the name.

Comment 1

[:aceman]

I'll see what can be done here.

Comment 2

[:aceman]

Attachment: patch

This one-liner should do it. Also works for exporting a single AB.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8774119 [details] [diff] [review]
patch

Review of attachment 8774119 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.
r=jorgk.

Comment 4

[:aceman]

https://hg.mozilla.org/comm-central/rev/556ae184177ecd169e6f7198879426b14d82f340

Comment 5

[Charles]

I was going to file a new bug to do this very thing, but to also eliminate the individual prompts for each Address Book.

I just added bug 133527 to change this so that there is only a single dialog that opens letting the user know they are about to export X Address Books with each named the same as the Address Book Name, with an OK or Cancel button. If OK is clicked, it will export them all without a dialog for each one using the Address Book Name for the file name.

This is all I'd like. While I can see the argument for an option in the dialog to export them with individual dialogs, I honestly don't really see any value in that, since they could always just rename them after the export. But, this could always be provided as an option on the first dialog - ie, an OK button, a Cancel button, and a 'Export each individually' button.

Comment 6

[David E. Ross]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

I just now noticed this bug report was marked Resolved/Fixed.  I tested it, and it is indeed fixed.  Thank you to those who coded and verified the fix.